https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38967 --- Comment #18 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- (In reply to Marcel de Rooy from comment #17)
(In reply to Tomás Cohen Arazi (tcohen) from comment #16)
(In reply to Jonathan Druart from comment #15)
Shouldnt we just add an exception to the failing unit test here?
No, we have other place where we have "dump cud-" for this same reason.
I meant that we can keep the op=cud- in the template without enforcing it in the controller (ie. allow the export for GET requests as well).
That's what my follow-up does. But shouldn't it be better to explicitly add an exception in the tests? That's why I didn't push the follow-up on behalf of Lucas.
And it is does the same as the follow-up of Lukas which we obsoleted.. If we add a test exception, we can remove the op parameter which is not checked in the controller. But left or right does not matter much here imo
I didn't notice the obsoleted patch. It makes sense. +1 for adding an exception. it is clearer -for the time being- than a weird "op" param to workaround our own checks. -- You are receiving this mail because: You are watching all bug changes.