http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10685 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20615|0 |1 is obsolete| | --- Comment #3 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 20647 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20647&action=edit Bug 10685: Inappropriate uses of finish in C4::Accounts.pm This patch gets rid of finish.
From the man page
finish() Indicate that no more data will be fetched from this statement handle before it is either executed again or destroyed. You almost certainly do not need to call this method. Adding calls to "finish" after loop that fetches all rows is a common mistake, don't do it, it can mask genuine problems like uncaught fetch errors. Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Comment: Similar to other patches from the same author. Run prove t/db_dependent/Accounts.t without errors No koha-qa errors Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> -- You are receiving this mail because: You are watching all bug changes.