https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26226 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #108399|0 |1 is obsolete| | --- Comment #2 from David Nind <david@davidnind.com> --- Created attachment 110779 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110779&action=edit Bug 26225: Move translatable strings out of biblio_framework.tt and into biblio_framework.js This patch removes the definition of translatable strings out of templates and into the corresponding JavaScript file, using the new JS i81n function. To test: - Apply the patch, go to Administration -> MARC bibliographic framework. - Click Actions -> Export and save the file. - Click Actions -> Import. - Select a file which isn't CSV or ODS. You should get an error message, "Please select a CSV (.csv) or ODS (.ods) spreadsheet file." - Select the file you exported previously and click "Import." You should see an error message, "Are you sure you want to replace the fields and subfields for the default framework structure? ..." - Click "OK." You should see a message in the modal window, "Importing to framework:..." - Edit your exported framework file in such a way that it isn't a valid framework export. - Repeat the process of importing the file. You should get an error message, "Error importing the framework..." TESTING TRANSLATABILITY - Update a translation, e.g. fr-FR:
cd misc/translator perl translate update fr-FR
- Open the corresponding .po file for JavaScript strings, e.g. misc/translator/po/fr-FR-messages-js.po - Locate strings pulled from koha-tmpl/intranet-tmpl/prog/js/biblio_framework.js for translation, e.g.: msgid "Please select a CSV (.csv) or ODS (.ods) spreadsheet file" msgstr "" - Edit the "msgstr" string however you want (it's just for testing). - Install the updated translation:
perl translate install fr-FR
- Switch to your newly translated language in the staff client and repeat the test plan above. The translated strings should appear. https://bugs.koha-community.org/show_bug.cgi?id=26226 Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.