https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8127 --- Comment #9 from David Nind <david@davidnind.com> --- Created attachment 199397 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=199397&action=edit Bug 8127: Fix filters use in 'Most-circulated items report' Filters are broken for many reasons. Previous patch contains some (little) tidying. There are 3 parts in this patch: 1 - The column name is incorrectly named in the dropdown for "branch", it is added in this patch 2 - There is a definition for 'Day' and 'Month', but not for 'Week', it is also added in this patch 3 - Dbh variables are passed in the string definition AND in the call. I removed them from the string definition since it violates the coding guidelines. Test plan: 1. On an fresh ktd db, run the script provided here (https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8127#c3) to fill the database with checkins/checkouts: Visit http://your_koha:8081/cgi-bin/koha/reports/cat_issues_top.pl 2. Run a baseline test with following params: Checkout date from 01/01/2020 Checkout date to: tomorrow Library: Any library Fill nothing else Notice it is works 3. Test with some limits (Library, Week, and any other), notice you encounter errors on Library and Week, and that any other is empty, without error. 4. Apply patch 5. Rerun 2-3 and notice you now have results. Check with each possible limit, limiting to 5. Test once with 10 as a limit. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.