https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23051 Andrew Isherwood <andrew.isherwood@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #94453|0 |1 is obsolete| | --- Comment #39 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- Created attachment 94525 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94525&action=edit Bug 23051: (follow-up) Refactor methods This follow up patch addresses the following parts of Nick's feedback in comment #35: - I don't really like that the functions are internal functions and then exported - I think the pref description should highlight that if 'RenewalPeriodBase' is set to due date, there may be doubled charges -- You are receiving this mail because: You are watching all bug changes.