https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15336 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen@gmail.com Status|Passed QA |In Discussion --- Comment #41 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Alex Arnaud from comment #33)
(In reply to Jonathan Druart from comment #31)
I do not understand why you put the transaction in the pl and not in the method, are there any good reasons?
My opinion is that commit or rollback should not take place in the API. As Katrin asked, we could use merge_with to add this feature on the GUI. In this case, what is point to have the transaction in there ? Will we offer the ability to "test" before confirm on the GUI ?
Tomas, Can I get your opinion on this please? I am expecting the whole move to be done in a transaction (handled by the method) and an exception raised if something failed. The dry-run mode could be done using nested transactions. -- You are receiving this mail because: You are watching all bug changes.