https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36307 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |m.de.rooy@rijksmuseum.nl |y.org | CC| |m.de.rooy@rijksmuseum.nl --- Comment #6 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- FIXED * Commit title does not start with 'Bug XXXXX: ' - eb3ef09d69 Following code could still be improved with error codes. (No blocker for me) foreach my $required_parameter ( qw( message destination ) ) { # Should I warn in some way? return unless defined $params->{ $required_parameter }; } eval { require SMS::Send; }; if ( $@ ) { # we apparently don't have SMS::Send. Return a failure. return; } Similarly (no blocker for me): return $sent; If $sent is 0, this could use a specific error code, I would say. Now we fallback to NO_NOTES. SMS::Send does not tell us much more, I am afraid. Provide a follow-up if you like. -- You are receiving this mail because: You are watching all bug changes.