https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41452 --- Comment #6 from David Cook <dcook@prosentient.com.au> --- Comment on attachment 195749 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=195749 Bug 41452 - Add optional "Beautify" formatting for CodeMirror SQL / JS / CSS editors Review of attachment 195749: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=41452&attachment=195749) ----------------------------------------------------------------- For the *.min.js files, you should add (alphabetical) references to them in ./koha-tmpl/intranet-tmpl/prog/en/modules/about.tt in the "BLOCK licenses_panel" section. ::: koha-tmpl/intranet-tmpl/js/beautify.js @@ +234,5 @@
+ // Create tooltip-like feedback + var feedback = document.createElement("span"); + feedback.className = "beautify-feedback"; + feedback.textContent = message; + feedback.style.cssText =
Why do inline styles here rather than including them in a file like you did for beautify-btn.css? ::: koha-tmpl/intranet-tmpl/lib/js-beautify/beautify-btn.css @@ +1,1 @@
+/* Beautify button styles for CodeMirror editors */
Is this custom CSS or does this come from the Beautify project? If it's custom, this file should be in ./koha-tmpl/intranet-tmpl/prog/css/ I believe -- You are receiving this mail because: You are watching all bug changes.