https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37605 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook@prosentient.com.au --- Comment #1 from David Cook <dcook@prosentient.com.au> --- (In reply to Martin Renvoize from comment #0)
I find the vue apps all use dialog where I feel 90% of the time it would be much more appropriate to use a bootstrap modal.
The inconsistency is stark.
It's a good question, and I don't think that I know the answer. My guess is that we might not have great Vue-Bootstrap integrations? If I look through all our .vue files, I don't see any references to the string "bootstrap". Whereas working with "dialog" elements is super easy in any Javascript. Recently, I was looking at replacing jQuery UI in a different app, and I was thinking about doing my own modals using <dialog>, but I probably will end up using Bootstrap modals. In the case of Koha, it probably does make sense to be consistent across the board, but maybe folks have reason for using <dialog> elements instead. On a related note, it looks like Bootstrap might start using "dialog" elements in Bootstrap 6 for modals. (I'd include the link but Bugzilla likes to autoban me when I post links...) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.