https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30239 Bug ID: 30239 Summary: Only items that are allowed to be reserved should be considered when checking if an item can be reserved Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Hold requests Assignee: koha-bugs@lists.koha-community.org Reporter: aleisha@catalyst.net.nz QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com The 'on shelf holds' circulation rule defines whether all or some items must be unavailable for a hold to be placed. If 'on shelf holds' is set so all items must be unavailable to place holds, then only items that allow reserves should be considered in that. For example: You have a record with a bunch of different itemtypes attached: Biblio A has three items - a book, a DVD, and a magazine. Books and DVDs have circulation rules where reserves are allowed (reserves allowed > 0). Magazines have a circulation rule where reserves are NOT allowed (reserves allowed == 0); 'On shelf holds' is set to 'all items must be unavailable'. The book and DVD for Biblio A are both checked out and the magazine is not. This means that all items that COULD be reserved are unavailable so a patron should be able to place a hold on them. However, because the magazine is not checked out, Koha things there is an item still available and blocks the patron from placing a hold, even though magazines are not allowed to be reserved. When checking if an item can be reserved based on the 'on shelf holds' rule, we should only consider items that allow reserves in the first place. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.