16 Jun
2023
16 Jun
'23
7:59 a.m.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30002 --- Comment #42 from Jonathan Druart <jonathan.druart+koha@gmail.com> ---
We should imo not fail patches for occurrences of if( $a ) or test( 1 ), since that was our style until this report..
"our" style? We didn't have any styles :D We simply need consistency. The QA check will WARN instead of FAIL to tell QA that it's not a strict failure. IMO we should fail (or adjust ourselves) for new blocks or new files. A couple of lines added to existing code should stick to the existing style. We can add or adjust options to perltidyrc, and discuss them. -- You are receiving this mail because: You are watching all bug changes.