https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18880 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #28 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Marcel de Rooy from comment #26)
LDAP behavior should be reverted in the sense of: - return 0 if $retval == -1; # Incorrect password for LDAP login attempt - ($retval) and return ( $retval, $retcard, $retuserid ); - } Your patch falls back to internal for -1; it should NOT do that. Internal fallback should be enabled only if retval == 0.
Right! - $check_internal_as_fallback = 1 if $retval == -1; + $check_internal_as_fallback = 1 if $retval == 0; -- You are receiving this mail because: You are watching all bug changes.