http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9394 --- Comment #32 from Jonathan Druart <jonathan.druart@biblibre.com> --- (In reply to comment #31)
(In reply to comment #29)
Created attachment 18466 [details] [review] [review] Bug 9394: QA Followup
* C4::Reserves::GetReserveId This subroutine did not have a unit test.
This new test fails for me. You pass an itemnumber to GetReserveId after an AddReserve with no itemnumber, so GetReserveId returns the wrong of the 2 existing reserves at that point. We could either remove the "itemnumber => $itemnumber," line or add modify the AddReserve above it. What do you think ?
Ho yes, of course! 50% chance, the test passes on my instance... I will resubmit the patch and switch back the status to Needs Signoff! -- You are receiving this mail because: You are watching all bug changes.