http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14368 --- Comment #13 from Matthias Meusburger <matthias.meusburger@biblibre.com> --- (In reply to Tomás Cohen Arazi from comment #12)
- There's a bug on the unit test you introduce for lifting the discharge, because it should look like:
ok( ! Koha::Borrower::Discharge::is_discharged({ borrowernumber => $borrowernumber }), 'The patron is not discharged after the restriction has been lifted' );
And you will notice it fails :/
Indeed. Misuse of DelDebarment. Fixed in the follow-up.
- There's a problem with Koha::Borrower::Discharge::discharge (not introduced by your patch, but affects the beaviour): it overwrites the already defined discharges... so no history! Heh.
Hmm, the sql patch introducing discharge_id in the discharges table and the following part of the patch should prevent this behavior, shouldn't it ? - my $discharge = $rs->search({ borrower => $borrowernumber }); + my $discharge = $rs->search({ borrower => $borrowernumber }, { order_by => { -desc => 'needed' }, rows => 1 }); -- You are receiving this mail because: You are watching all bug changes.