https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35117 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #10 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Hi Marcel, Thanks again for the review. I have rebased Nick's patch on current main and attached a follow-up for your point about a missing 001: with UseControlNumber on and no 001, get_components_query and get_volumes_query now fall back to the title search, as they do when UseControlNumber is off, so a search is never built from an undefined value. I added tests for it, and fixed a test the original patch had broken. While preparing this I went through the related bugs and found two overlaps worth agreeing on: - Bug 41713 fixes the same warnings from the other end, by passing an empty string when there is no search string, and changing detail.pl. With this follow-up a search string is always built, so I would keep the unit tests and Pedro's two points from 41713 and drop the "// ''" change. I have put the details on that bug. - Bug 39287 adds a more specific index for the volumes search, which is the other half of making the two methods consistent. I think it is worth getting that one moving too. One caveat on the title fallback: it uses the same title phrase search as UseControlNumber off, which bugs 43113 and 26480 report as too broad. I think a broad match is better than searching for an undefined value, but if you would rather return nothing when there is no 001 I am happy to change it. I am setting this back to Needs Signoff. -- You are receiving this mail because: You are watching all bug changes.