https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18904 --- Comment #19 from Nick Clemens <nick@bywatersolutions.com> --- (In reply to Marcel de Rooy from comment #14)
I have the impression that you fix one or two bugs here in blinddetail that should go on their own. Please split. Created 19537 - the subfield order patch makes no sense on its own as it has no effect outside of rancor
Also I would rather not change blinddetail for Rancor, but replace what you need on the receiving side. (experimental etc.) I looked, but it doesn't make sense to me to move it - blinddetail does the replacement of the text in the record and we do similar fixing of text for traditional editor
+ index = 'rancor';//+field.line+'|'+field.tag; Debugging leftover? Fixed
+ [%- FOREACH authtag = authtags -%] Hmm. Doesnt look nice. Not sure what part you don't like here? Makes sense to me
+ var cur_field = opener.opener.jQuery(".CodeMirror")[0].CodeMirror.marceditor. getCurrentField(); What are you doing here exactly ? Why opener.opener ? Same as traditional - editor opens auth-finder which opens blinddetail - opener.opener gets us back to the place we called from (the editor)
-- You are receiving this mail because: You are watching all bug changes.