https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42165 --- Comment #7 from Laura Escamilla <Laura.escamilla@bywatersolutions.com> --- (In reply to Brendan Lawlor from comment #6)
Thanks for working on this Laura! This might not be a blocker but before I Pass QA, I'm interested in hearing others thoughts.
I tested this with NVDA screen reader and I think that we could remove the aria-label to reduce some of that screen reader "noise".
With role="search" and aria-label="Catalog search"
Upon entering the search form it says 'Catalog search, search landmark, search the catalog by, combo box Library catalog collapsed' which is heavy to process at once.
W3C advises Avoid using the landmark role as part of the label. https://www.w3.org/WAI/ARIA/apg/patterns/landmarks/examples/general- principles.html
I think this is a common issue that screen reader users are used to dealing with, but we could possibly make their experience a little better.
If there are no other search landmarks on the page, then it doesn't need to have an aria-label: https://www.w3.org/WAI/ARIA/apg/patterns/landmarks/examples/search.html
git grep 'role="search"' only comes up in masthead.inc and one form in the staff interface, so I think this would be valid in this case.
The only issue would be if another search landmark were introduced on a page that includes masthead.inc, then each one would need a unique label.
Without the aria label the screen reader announces entering the form like 'Search landmark, search the catalog by, combo box Library catalog collapsed' which flows a little better.
Thanks for testing with NVDA and for the thoughtful feedback. I agree that in this case the aria-label may be adding unnecessary verbosity. Since masthead.inc appears to provide the only search landmark on these pages, role="search" should be sufficient without an additional label. I'll update the patch to remove the aria-label and leave the search landmark in place. -- You are receiving this mail because: You are watching all bug changes.