http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14337 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41788|0 |1 is obsolete| | --- Comment #21 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 41905 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41905&action=edit Bug 14337 - AllowRenewalIfOtherItemsAvailable counts holdable not for loan items when checking renewability AllowRenewalIfOtherItemsAvailable checks C4::Reserves::IsAvailableForItemLevelRequest to see if the item is holdable, which catches not for loan values less than 0 ( i.e. holdable, but not circ-able ). However, since this feature is about actually checking out items to patrons, we should not count *any* not for loan items when deciding if the available items will satisfy all current holds. Test Plan: 1) Enable AllowRenewalIfOtherItemsAvailable 2) Create a record with two items 3) Check out one item to a patron 4) Ensure the item is renewable 5) Place a hold on the record 6) The item should now be non-renewable 7) Add a second item to the record, but with a not for loan value < 0 8) Note the checkout is still renewable 9) Apply this patch 10) Note the checkout is now non-renewable Works ok. Signed-off-by: Amit Gupta <amit.gupta@informaticsglobal.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.