https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42857 Bug ID: 42857 Summary: AddReturn early returns skip transfer processing (wrong branch, withdrawn) Initiative type: --- Sponsorship --- status: Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: martin.renvoize@openfifth.co.uk QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle@bywatersolutions.com Blocks: 42851 Target Milestone: --- Split off from bug 42851. AddReturn has early-return paths that fire BEFORE the transfer-receive block at C4/Circulation.pm:2553: - "Return not allowed at this branch" (CanBookBeReturned fails) returns at C4/Circulation.pm:2435. - Withdrawn item with BlockReturnOfWithdrawnItems returns at C4/Circulation.pm:2362. If an in-transit item is scanned at such a branch, the transfer is never touched and the row is orphaned on the "Transfers to receive" report. Proposed approach: an item arriving at its transfer destination should override the check-in block. More generally, transfer processing should run (or at least be evaluated) even on these blocked-return paths, so an active transfer is correctly received/resolved before the block is applied. Test plan: 1. Set up a circulation rule / withdrawn-block that blocks return at branch B. 2. Transfer an item to B (in transit). 3. Check it in at B. 4. Before: return blocked, transfer left in transit. 5. After: arrival at the destination is honoured and the transfer is received. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42851 [Bug 42851] [OMNIBUS] Items left stuck in transit when checked in outside the staff returns page -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.