https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33363 --- Comment #27 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Kyle M Hall from comment #26)
2) What is actually meant by "manage"?
I assume that "manage" actually means "edit". While any of the permissions allow to "view".
If that is the case, I feel it would be good to adjust the permission descriptions accordingly.
That was the pre-existing term and in Koha we've always used it as a catch-all for anything not covered by more specific permissions. It covers more than just viewing, such as approvals.
We have used it as a catch all, I agree, it meant: CRUD. But now that we are starting to split permissions up, I think we should try to be as precise in our descriptions as possible.
I disagree with that interpretation, but I'm open to other possibilities. I think we've hit something philosophical that it far outside the scope of this development. Maybe we should discuss this at the next dev meeting?
Maybe I am misunderstanding... but with manage_suggestions I can no longer delete/create now. So it feels absolutely necessary to me to adapt the permission description?
Can you add a screenshot or be more specific about where this pulldown is?
The "More" in the main navigation of Koha on top of every page :)
I think it should probably be visible with "any" suggestion permission, what do you think?
The same for the acquisition module navigation on the left.
You found a bug! Fixed!
3) Question
+ <div class="note">Only staff with superlibrarian or full suggestions permissions are returned in the search results</div>
I think this is in line with the previous behavior, but I wonder if we should not change to allow "any" instead of "full" here.
I disagree. This is still a limit for just librarians that manage permissions, just like all the other manage permissions we can limit patron searches too.
I assume this is for setting the manager of a suggestion - editing might be required, but not sure if delete and create would be as well.
They would not be.
But if the search is limited to must have "all module" permissions, I cannot edit someone that has only manage or only delete or only create to be a manager. I think the "only manage" could maybe be a use case?
I'm not sure I understand. Those searches are already filtering for the "suggestions_manage". Those searches are for setting a manager for the suggestion. Everything works as is, right? I did not make any changes to this code.
I was referring to these lines here: - <div class="note">Only staff with superlibrarian or suggestions_manage permissions are returned in the search results</div> + <div class="note">Only staff with superlibrarian or full suggestions permissions are returned in the search results</div> -- You are receiving this mail because: You are watching all bug changes.