https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28058 --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 119024 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119024&action=edit Bug 28058: Move javascript out of columns_settings.inc into separate file This patch moves the JavaScript contained in a <script> block inside columns_settings.inc into a separate file. The new JavaScript file, tablesettings.js, contains some corrections to minor errors highlighted by eslint (missing semicolons, undeclared variables, etc). I'm also moving the contents of table_filters.js into tablesettings.js and removing table_filters.js. I don't think it necessary to have a whole separate JS file which is only used on pages which already include columns_settings.inc. To test, apply the patch and perform a catalog search in the staff client. - On the bibliographic detail page, confirm that the table of holdings still works correctly: Sorting, search, column filters, and export. - Confirm that clicking the "Activate filters" control activates the filter fields at the top of each table column. - Go to Reports -> Lost items and perform the same tests. -- You are receiving this mail because: You are watching all bug changes.