https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26517 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hm, a few small things: 1) if a user has only subpermissions, flags are 0. Should we extend the check to take care of these? I could imagine someone removing catalog permission for someone temporarily not working at the library, but expected to return. 2) I think all the tests for GetBororwersToExpunge should be grouped into a subtest (but this was an issue before your patch) 3) All patrons I see in the tests have flags = undef... am I missing the one blocked from deleting for flags? -- You are receiving this mail because: You are watching all bug changes.