http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11247 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff --- Comment #13 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Srdjan Jankovic from comment #11)
Sorry, I did not know what to do with it. My intention was to correct something that I found obviusly wrong when doing some other work. I did not want to go into changing the way things work. I'm happy for this to be dropped, but the fact stays that the code as it is now is wrong. It works just because it is being called in particular way.
I amended your path in order to not lose everything including your remarks about wrong calls and a param not being used. (Adding a comment) I switched the params at three places where they were in reverse order. Added a trivial unit test. Since the indicator param works fine, I favored leaving it here. -- You are receiving this mail because: You are watching all bug changes.