http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7001 --- Comment #84 from Srdjan Jankovic <srdjan@catalyst.net.nz> 2012-03-01 23:53:00 UTC --- (In reply to comment #83)
Main patch is looking good...I need a little more time with it to do a full analysis for QA, but one thing has come up.
In C4/Letters getletter() subroutine, there is a hash my %letter defined outside the subroutine. This is later modified in the subroutine. I'm not exactly sure why,
That is a workaround for not using objects. It is a cache/stash.
and to the best of my knowledge, this will cause scope problems with mod_perl and other fast CGI alternatives. I think we'll get a
Variable "%letter" will not stay shared at...
if we try to use mod_perl.
That definitely should not happen. "will not stay shared" would happen if using perl threads, but I'm not sure if anyone is using that any more.
Can you confirm the reasoning behind this coding set up,
Just saves resources when getletter() is called multiple times in one run, like batch notice generation.
and whether it would be a lot of work to reimplement not to use this method?
As it is now, we can only drop it. But a little bird told me that C4 will be replaced with Koha, which will be object based, and the problem will disappear then.
Or perhaps you can confirm that this is not actually a problem in mod_perl? My understanding may be flawed here.
It has a potential to make problems in mod_perl, if notice records on the database are changed and server process not reloaded. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.