https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31224 Bug ID: 31224 Summary: Koha::Biblio::Metadata->record should use the EmbedItems filter Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs@lists.koha-community.org Reporter: tomascohen@gmail.com QA Contact: testopia@bugs.koha-community.org Bug 29697 removed GetMarcBiblio in favor of using Koha::Biblio::Metadata->record. YAY! But it added a redundant Koha::Biblio::Metadata::_embed_items method. It also adds a suspicious 'record' param. I say suspicious because it looks like a trick to have a given MARC::Record object added the items information. Which feels like wrong API design. Specially when we have the Koha::Filter::MARC::EmbedItems processor filter for the task. Now that things are 'modernized' we really need to revisit this code for a cleanup. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.