https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17669 --- Comment #37 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Jonathan Druart from comment #36)
Very small thing again, delete_temporary returns true if no errors occur. I am wondering if we should not return true if the delete worked.
92 } elsif( !defined($days) || $days eq '' ) { # allow 0, not NULL or "" 93 return 1; 94 }
would then be 'return;'
It's how delete and delete_missing work.
Hope we still make it before release :) I agree that we should make this more consistent. But returning undef is perhaps not the best solution. I will add a follow-up that returns 0E0 just as DBIx does when DBI is the storage backend. This affects UploadedFile too. Only a few small changes, but more than one line.. -- You are receiving this mail because: You are watching all bug changes.