https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41780 --- Comment #36 from Chris Mathevet <chris.mathevet@inLibro.com> --- (In reply to David Nind from comment #31)
I've signed off, as things work as per the test plan.
However, I'm really not a fan of the way the names are shown when there is a preferred name and a first name.
It is not a pattern we've used elsewhere in Koha, and not something I've seen in other web-based applications.
It displays as "Alex | Alexandra Surname (987654321)", where Alexandra is in italics and a smaller text size.
Some options (which I'm sure have been debated endlessly on this and other bugs): 1. Preferred name Surname (card number): For example, Alex Surname (987654321) 2. Preferred name (First name) Surname (card number): For example, Alex (Alexandra) Surname (987654321) 2. First name (Preferred name) Surname (card number): For example, Alexandra (Alex) Surname (987654321)
My strong preference is for preferred name surname (card number), which is the current way it is shown. (As the default standard patron search returns the correct result if either the preferred name or first name are used.)
Following this comment, I updated the patch to display the firstname only when the preferred name is null or empty. The implementation now uses a more robust approach. The previous patch also introduced additional regressions. One example is that the link to the borrower account from the checkout page was broken due to the first name being rendered in italics. -- You are receiving this mail because: You are watching all bug changes.