https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17457 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #12 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Jonathan Druart from comment #10)
Tests are MARC21 specific, please provide a version for UNIMARC. I would suggest to create a MARC::Record manually instead of using a MARC XML. See what is done in t/db_dependent/Biblio.t
Imho adding a sample UNIMARC record with a ISBN would have been much simpler than following Biblio.t. This is unnecessary code complexity/duplication (120 lines extra for a UNIMARC ISBN). David is to be commended for this efforts. But personally I would prefer to push without the second patch. I will pass QA without additional signoff to let Jonathan handle it. -- You are receiving this mail because: You are watching all bug changes.