http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12788 --- Comment #1 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 31002 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31002&action=edit Bub 12788: (regression test) refactor facet extraction code to allow testing This patch refactors the facet extraction loop into a proper function. The loop is changed so the MARC::Record objects are created only once instead of the old/current behaviour: once for each defined facet (in C4::Koha::getFacets). To test: - Apply the patch => SUCCESS: verify facets functionality remains unchanged. - Run: $ prove -v t/db_dependent/Search.t => SUCCESS: tests for _get_facets_data_from_record fail, because 100$a is considered for fields with indicator 1=z (field added by IncludeSeeFromInSearches syspref). - Sign off :-D Sponsored-by: Universidad Nacional de Cordoba -- You are receiving this mail because: You are watching all bug changes.