https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36954 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com --- Comment #4 from David Nind <david@davidnind.com> --- I had a go at testing, not that I understand SIP and the discussion (I'm also not sure what "..that logging is still done as expected" looks like). What I noticed: 1. For most of the entries that were previously in sip-output.log, in the new log they have "[WARN] [undef]@[undef]", previously they didn't have anything. Comment: 1. For the logs for other services, there tends to be a full log, and then errors separated out into a separate [service]-error.log. 2. Should we be doing the same here, so as not to break this pattern? How I tested (using KTD): 1. Before the patch, I started up KTD and reviewed the output of the logs. 2. After the patch, I shut down KTD and restarted, and reviewed the output of the logs. 3. I didn't try any SIP transactions to see what was logged. Separate log files before the patch ----------------------------------- sip-error.log 1 [2025/01/29 17:12:52] [914] [ERROR] [undef]@[undef]: ERROR: Institution kohalibrary2 does does not match a branchcode. This can cause unexpected behavior. C4::SIP::Sip::siplog /kohadevbox/koha/C4/SIP/Sip.pm (234) 2 [2025/01/29 17:12:52] [914] [ERROR] [undef]@[undef]: ERROR: Institution kohalibrary does does not match a branchcode. This can c ause unexpected behavior. C4::SIP::Sip::siplog /kohadevbox/koha/C4/SIP/Sip.pm (234) 3 [2025/01/29 17:12:52] [914] [ERROR] [undef]@[undef]: ERROR: Institution MAIN does does not match a branchcode. This can cause un expected behavior. C4::SIP::Sip::siplog /kohadevbox/koha/C4/SIP/Sip.pm (234) 4 [2025/01/29 17:12:52] [914] [WARN] [undef]@[undef]: 2025/01/29-17:12:52 C4::SIP::SIPServer (type Net::Server::PreFork) starting! pid(914) Net::Server::run /usr/share/perl5/Net/Server.pm (52) 5 [2025/01/29 17:12:52] [914] [WARN] [undef]@[undef]: 2025/01/29-17:12:52 C4::SIP::SIPServer (type Net::Server::PreFork) starting! pid(914) Net::Server::log /usr/share/perl5/Net/Server.pm (962) 6 [2025/01/29 17:12:52] [914] [WARN] [undef]@[undef]: Binding to TCP port 8023 on host 127.0.0.1 with IPv4 Net::Server::bind /usr/ share/perl5/Net/Server.pm (328) 7 [2025/01/29 17:12:52] [914] [WARN] [undef]@[undef]: Binding to TCP port 8023 on host 127.0.0.1 with IPv4 Net::Server::log /usr/s hare/perl5/Net/Server.pm (962) 8 [2025/01/29 17:12:52] [914] [WARN] [undef]@[undef]: Binding to TCP port 6001 on host 127.0.0.1 with IPv4 Net::Server::bind /usr/ share/perl5/Net/Server.pm (328) 9 [2025/01/29 17:12:52] [914] [WARN] [undef]@[undef]: Binding to TCP port 6001 on host 127.0.0.1 with IPv4 Net::Server::log /usr/s hare/perl5/Net/Server.pm (962) 10 [2025/01/29 17:12:52] [914] [WARN] [undef]@[undef]: Setting gid to "1000 1000" Net::Server::post_bind /usr/share/perl5/Net/Serve r.pm (391) 11 [2025/01/29 17:12:52] [914] [WARN] [undef]@[undef]: Setting gid to "1000 1000" Net::Server::log /usr/share/perl5/Net/Server.pm ( 962) sip-output.log: 1 2025/01/29-17:12:52 C4::SIP::SIPServer (type Net::Server::PreFork) starting! pid(914) 2 Binding to TCP port 8023 on host 127.0.0.1 with IPv4 3 Binding to TCP port 6001 on host 127.0.0.1 with IPv4 4 Setting gid to "1000 1000" Combined sip.log after the patch -------------------------------- 1 [2025/01/29 18:22:38] [910] [ERROR] [undef]@[undef]: ERROR: Institution kohalibrary does does not match a branchcode. This can cause unexpected behavior. C4::SIP ::Sip::siplog /kohadevbox/koha/C4/SIP/Sip.pm (234) 2 [2025/01/29 18:22:38] [910] [ERROR] [undef]@[undef]: ERROR: Institution kohalibrary2 does does not match a branchcode. This can cause unexpected behavior. C4::SI P::Sip::siplog /kohadevbox/koha/C4/SIP/Sip.pm (234) 3 [2025/01/29 18:22:38] [910] [ERROR] [undef]@[undef]: ERROR: Institution MAIN does does not match a branchcode. This can cause unexpected behavior. C4::SIP::Sip:: siplog /kohadevbox/koha/C4/SIP/Sip.pm (234) 4 2025/01/29-18:22:38 C4::SIP::SIPServer (type Net::Server::PreFork) starting! pid(910) 5 [2025/01/29 18:22:38] [910] [WARN] [undef]@[undef]: 2025/01/29-18:22:38 C4::SIP::SIPServer (type Net::Server::PreFork) starting! pid(910) Net::Server::run /usr/s hare/perl5/Net/Server.pm (52) 6 [2025/01/29 18:22:38] [910] [WARN] [undef]@[undef]: 2025/01/29-18:22:38 C4::SIP::SIPServer (type Net::Server::PreFork) starting! pid(910) Net::Server::log /usr/s hare/perl5/Net/Server.pm (962) 7 Binding to TCP port 8023 on host 127.0.0.1 with IPv4 8 [2025/01/29 18:22:38] [910] [WARN] [undef]@[undef]: Binding to TCP port 8023 on host 127.0.0.1 with IPv4 Net::Server::bind /usr/share/perl5/Net/Server.pm (328) 9 [2025/01/29 18:22:38] [910] [WARN] [undef]@[undef]: Binding to TCP port 8023 on host 127.0.0.1 with IPv4 Net::Server::log /usr/share/perl5/Net/Server.pm (962) 10 Binding to TCP port 6001 on host 127.0.0.1 with IPv4 11 [2025/01/29 18:22:38] [910] [WARN] [undef]@[undef]: Binding to TCP port 6001 on host 127.0.0.1 with IPv4 Net::Server::bind /usr/share/perl5/Net/Server.pm (328) 12 [2025/01/29 18:22:38] [910] [WARN] [undef]@[undef]: Binding to TCP port 6001 on host 127.0.0.1 with IPv4 Net::Server::log /usr/share/perl5/Net/Server.pm (962) 13 Setting gid to "1000 1000" 14 [2025/01/29 18:22:38] [910] [WARN] [undef]@[undef]: Setting gid to "1000 1000" Net::Server::post_bind /usr/share/perl5/Net/Server.pm (391) 15 [2025/01/29 18:22:38] [910] [WARN] [undef]@[undef]: Setting gid to "1000 1000" Net::Server::log /usr/share/perl5/Net/Server.pm (962) -- You are receiving this mail because: You are watching all bug changes.