https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39637 Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Component|Patrons |REST API CC| |jonathan.druart@gmail.com, | |martin.renvoize@openfifth.c | |o.uk, tomascohen@gmail.com --- Comment #19 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- Hi, I just noticed this attempt to make a big change on the API architecture. Lucas brought it to me. Adding Jonathan and Martin to the conversation as well. I saw several reports about the same and I agree with the basics of this implementation: i.e. a query parameter for telling what to search, and another one for where. What we lack here is: * The query builder should be a helper in `Koha::REST::Plugin::Query` * Retrieving the parameters and building a query (with the helper) should be backed into `objects.search`. * The JS part should be done in datatables.js so we fix all tables the same way. The patrons one has a lot of fields to query on because of the extended attributes, but so the ILL one, etc. * I would add an option parameter to KohaTable, something like `compact_search: true` to choose which kind of search to build. This way we can migrate the tables one by one, taking care of their specifics. I'm willing to help here. My two cents. -- You are receiving this mail because: You are watching all bug changes.