https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42432 --- Comment #7 from David Nind <david@davidnind.com> --- The tests are still failing for me (everything else in the first patch works as expected). Testing notes (using KTD): 1. Apply the second patch (cypress tests) 2. yarn build (don't think this is required) 3. restart_all 4. Tests fail (doesn't matter if AllowRenewalOnHoldOverride is set to allow or not) cypress run --spec t/cypress/integration/Circulation/OnHoldDueDate_spec.ts 5. Reset everything as normal: - git checkout main - git branch -D bz42432 - git reset --hard oriin/main - reset_all 6. Apply both patches 7. Tests fail (doesn't matter if AllowRenewalOnHoldOverride is set to allow or not, although different results) Cypress regression patch only ============================= With AllowRenewalOnHoldOverride set to don't allow -------------------------------------------------- Circulation - AllowRenewalOnHoldOverride 'On hold due date' 1) sends the 'On hold due date' value to svc/renew for on-hold items ✓ falls back to 'Renewal due date' for non-on-hold items (5303ms) 1 passing (22s) 1 failing 1) Circulation - AllowRenewalOnHoldOverride 'On hold due date' sends the 'On hold due date' value to svc/renew for on-hold items: CypressError: Timed out retrying after 10050ms: `cy.check()` failed because this element is not visible: `<input type="checkbox" data-on-reserve="" class="renew" id="renew_973" name="renew" value="973">` This element `<input#renew_973.renew>` is not visible because its parent `<span.renewals-allowed-on_reserve>` has CSS property: `display: none` Fix this problem, or use `{force: true}` to disable error checking. https://on.cypress.io/element-cannot-be-interacted-with .... With AllowRenewalOnHoldOverride set to allow -------------------------------------------- Circulation - AllowRenewalOnHoldOverride 'On hold due date' 1) sends the 'On hold due date' value to svc/renew for on-hold items ✓ falls back to 'Renewal due date' for non-on-hold items (5313ms) 1 passing (12s) 1 failing 1) Circulation - AllowRenewalOnHoldOverride 'On hold due date' sends the 'On hold due date' value to svc/renew for on-hold items: AssertionError: expected '2099-05-05 23:59' to equal '2099-06-15 23:59' + expected - actual -'2099-05-05 23:59' +'2099-06-15 23:59' Both patches applied ==================== With AllowRenewalOnHoldOverride set to don't allow -------------------------------------------------- Running: OnHoldDueDate_spec.ts (1 of 1) Circulation - AllowRenewalOnHoldOverride 'On hold due date' ✓ sends the 'On hold due date' value to svc/renew for on-hold items (6546ms) 1) falls back to 'Renewal due date' for non-on-hold items 1 passing (23s) 1 failing 1) Circulation - AllowRenewalOnHoldOverride 'On hold due date' falls back to 'Renewal due date' for non-on-hold items: CypressError: Timed out retrying after 10050ms: `cy.check()` failed because the center of this element is hidden from view: `<input type="checkbox" class="renew" id="renew_981" name="renew" value="981">` Fix this problem, or use `{force: true}` to disable error checking. https://on.cypress.io/element-cannot-be-interacted-with ... With AllowRenewalOnHoldOverride set to allow -------------------------------------------- Running: OnHoldDueDate_spec.ts (1 of 1) Circulation - AllowRenewalOnHoldOverride 'On hold due date' 1) sends the 'On hold due date' value to svc/renew for on-hold items ✓ falls back to 'Renewal due date' for non-on-hold items (5619ms) 1 passing (22s) 1 failing 1) Circulation - AllowRenewalOnHoldOverride 'On hold due date' sends the 'On hold due date' value to svc/renew for on-hold items: CypressError: Timed out retrying after 10050ms: `cy.check()` failed because this element is not visible: `<input type="checkbox" data-on-reserve="" class="renew" id="renew_973" name="renew" value="973">` This element `<input#renew_973.renew>` is not visible because its parent `<span.renewals-allowed-on_reserve>` has CSS property: `display: none` Fix this problem, or use `{force: true}` to disable error checking. https://on.cypress.io/element-cannot-be-interacted-with -- You are receiving this mail because: You are watching all bug changes.