[Bug 27830] New: OPAC library list does not use AddressFormat
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27830 Bug ID: 27830 Summary: OPAC library list does not use AddressFormat Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: OPAC Assignee: oleonard@myacpl.org Reporter: magnus@libriotech.no QA Contact: testopia@bugs.koha-community.org Bug 13388 introduced the page of library info at /cgi-bin/koha/opac-library.pl. As far as I can tell, the address display on this page does not respect the AddressFormat syspref. Specifically, it displays the ZIP code after the city/state, but both the fr and de setting would display it the other way round. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27830 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27830 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 117731 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117731&action=edit Bug 27830: OPAC library list does not use AddressFormat This patch adds a new include file for displaying library addresses according to the AddressFormat system preference. It differs from the include file used for patrons in the staff interface because library addresses don't use streetnumber or road types. To test, apply the patch and rebuild the OPAC CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff...). - Make sure you have fill address information entered for at least one library. - In the OPAC, view the "Libraries" page. - Check that the format of the library addresses is correct when using any of the three address formats: de, fr, and us. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27830 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27830 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #117731|0 |1 is obsolete| | --- Comment #2 from David Nind <david@davidnind.com> --- Created attachment 119438 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119438&action=edit Bug 27830: OPAC library list does not use AddressFormat This patch adds a new include file for displaying library addresses according to the AddressFormat system preference. It differs from the include file used for patrons in the staff interface because library addresses don't use streetnumber or road types. To test, apply the patch and rebuild the OPAC CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff...). - Make sure you have fill address information entered for at least one library. - In the OPAC, view the "Libraries" page. - Check that the format of the library addresses is correct when using any of the three address formats: de, fr, and us. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27830 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |jonathan.druart@bugs.koha-c | |ommunity.org --- Comment #3 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- 1. For US there is an extra space after the city name and before the comma: Jefferson Summit line 2 line 3 city , state 1235 country 2. DE and FR seems very similar, however when comparing there are inconsistencies: "property" values are not the same and differ, please double-check (postalCode, addressRegion, etc.) 3. If DE and FR are identical at the end we should have not the code duplicate (keep display-library-address-fr and display-library-address-de but call a generic new one from them)) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27830 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27830 --- Comment #4 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 119559 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119559&action=edit Bug 27830: (follow-up) Merge DE and FR address formats Library addresses don't include the use of "Street Type" and "Street Number." DE and FR address formats differ only in the position of street type and number in the address sequence. This patch merges DE and FR address markup and uses the unified block if the address format system preference ISN'T "us". -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27830 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27830 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #119438|0 |1 is obsolete| | --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 119807 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119807&action=edit Bug 27830: OPAC library list does not use AddressFormat This patch adds a new include file for displaying library addresses according to the AddressFormat system preference. It differs from the include file used for patrons in the staff interface because library addresses don't use streetnumber or road types. To test, apply the patch and rebuild the OPAC CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff...). - Make sure you have fill address information entered for at least one library. - In the OPAC, view the "Libraries" page. - Check that the format of the library addresses is correct when using any of the three address formats: de, fr, and us. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27830 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #119559|0 |1 is obsolete| | --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 119808 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119808&action=edit Bug 27830: (follow-up) Merge DE and FR address formats Library addresses don't include the use of "Street Type" and "Street Number." DE and FR address formats differ only in the position of street type and number in the address sequence. This patch merges DE and FR address markup and uses the unified block if the address format system preference ISN'T "us". Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27830 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |21.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27830 --- Comment #7 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 21.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27830 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|21.05.00 |21.05.00,20.11.06 released in| | Status|Pushed to master |Pushed to stable CC| |fridolin.somers@biblibre.co | |m --- Comment #8 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to 20.11.x for 20.11.06 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27830 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrew@bywatersolutions.com --- Comment #9 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Doesn't apply cleanly to 20.05, please rebase if needed. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org