[Bug 27277] New: Queued vs Enqueued
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27277 Bug ID: 27277 Summary: Queued vs Enqueued Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: jonathan.druart@bugs.koha-community.org QA Contact: testopia@bugs.koha-community.org See bug 27109 comment 5: """ Rather than "Enqueued" I think I would prefer "Queued". Enqueued is a valid English word, according to Oxford English Dictionary (https://www.lexico.com/definition/enqueue). However, it is not something in common usage or that I have come across before except in Koha. As this one improves the display, I've signed it off. I will add a new bug for changing the term and see what others think. Testing notes: - Applied patch: applied successfully - Reviewed diff, makes sense to me """ Then comment 9 """ (In reply to David Nind from comment #5)
Rather than "Enqueued" I think I would prefer "Queued". Enqueued is a valid English word, according to Oxford English Dictionary (https://www.lexico.com/definition/enqueue). However, it is not something in common usage or that I have come across before except in Koha.
I love enqueue/dequeue and they come up a lot for me, but they do seem to be computing terms, so I am willing to admit that they probably should be reserved for backend systems and not displayed to users. I also love splitting hairs so... Should it be "Queued on" or "Queued at"? """ And don't forget there is also "Started on" -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27277 --- Comment #1 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 114511 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114511&action=edit Bug 27277: Replace 'Enqueued' with 'Queue' -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27277 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |In Discussion Patch complexity|--- |String patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27277 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |27109 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27109 [Bug 27109] Better labels for background job details -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27277 --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- (In reply to Jonathan Druart from comment #0)
Should it be "Queued on" or "Queued at"?
I agree with the change to "Queued" and I think we should drop the "on" altogether. Instead of "Queued on," "Started on," and "Ended on" we should use "Queued," "Started," and "Ended." -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27277 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Academy -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27277 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27277 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |NEW -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27277 James O'Keeffe <jamespfk@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |jamespfk@gmail.com Assignee|oleonard@myacpl.org |jamespfk@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27277 James O'Keeffe <jamespfk@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27277 --- Comment #3 from James O'Keeffe <jamespfk@gmail.com> --- Created attachment 115284 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115284&action=edit Bug 27277: Queued Vs Enqueued This patch changes "Enqueued on", "Started on", and "Ended on" to "Queued", "Started", and "Ended" respectively on the bacground jobs page. Task plan: 1. Navigate to the background jobs page 2. Ensure the spelling change, and that the spelling is correct. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27277 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #114511|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27277 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #4 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Hi James, thanks for your patch! There are other occurrences to fix in the same file: 152 <th>Enqueued on</th> 153 <th>Started on</th> 154 <th>Ended on</th> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27277 James O'Keeffe <jamespfk@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27277 --- Comment #5 from James O'Keeffe <jamespfk@gmail.com> --- Created attachment 115352 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115352&action=edit Bug 27277: Queued vs Enqueued Changed the other occurences of "Enqueued on", "Started on", and "Ended on" to "Queued", "Started", and "Ended" (As pointed out by Jonathan). Task Plan: 1. Navigate to th background jobs page 2. Ensure that the spelling of the changes are correct, and that there are no other instances of "Enqueued on", "Started on", and "Ended on" that have been missed. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27277 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27277 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #115284|0 |1 is obsolete| | Attachment #115352|0 |1 is obsolete| | --- Comment #6 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 119595 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119595&action=edit Bug 27277: Queued Vs Enqueued This patch changes "Enqueued on", "Started on", and "Ended on" to "Queued", "Started", and "Ended" respectively on the bacground jobs page. Task plan: 1. Navigate to the background jobs page 2. Ensure the spelling change, and that the spelling is correct. Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27277 --- Comment #7 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 119596 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119596&action=edit Bug 27277: Queued vs Enqueued Changed the other occurences of "Enqueued on", "Started on", and "Ended on" to "Queued", "Started", and "Ended" (As pointed out by Jonathan). Task Plan: 1. Navigate to th background jobs page 2. Ensure that the spelling of the changes are correct, and that there are no other instances of "Enqueued on", "Started on", and "Ended on" that have been missed. Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27277 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |28149 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28149 [Bug 28149] Improve internationalization and formatting on background jobs page -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27277 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #119595|0 |1 is obsolete| | --- Comment #8 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 119736 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119736&action=edit Bug 27277: Queued Vs Enqueued This patch changes "Enqueued on", "Started on", and "Ended on" to "Queued", "Started", and "Ended" respectively on the bacground jobs page. Task plan: 1. Navigate to the background jobs page 2. Ensure the spelling change, and that the spelling is correct. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Julian Maurice <julian.maurice@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27277 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #119596|0 |1 is obsolete| | --- Comment #9 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 119737 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119737&action=edit Bug 27277: Queued vs Enqueued Changed the other occurences of "Enqueued on", "Started on", and "Ended on" to "Queued", "Started", and "Ended" (As pointed out by Jonathan). Task Plan: 1. Navigate to th background jobs page 2. Ensure that the spelling of the changes are correct, and that there are no other instances of "Enqueued on", "Started on", and "Ended on" that have been missed. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Julian Maurice <julian.maurice@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27277 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |julian.maurice@biblibre.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27277 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |21.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27277 --- Comment #10 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 21.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27277 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m Status|Pushed to master |Pushed to stable Version(s)|21.05.00 |21.05.00,20.11.06 released in| | --- Comment #11 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to 20.11.x for 20.11.06 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27277 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrew@bywatersolutions.com --- Comment #12 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Doesn't apply cleanly to 20.05, please rebase if needed -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org