[Bug 28679] New: Unable to click "Log in to your account" when GoogleOpenIDConnect is enabled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28679 Bug ID: 28679 Summary: Unable to click "Log in to your account" when GoogleOpenIDConnect is enabled Change sponsored?: --- Product: Koha Version: 21.05 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard@myacpl.org Reporter: chad@pennmanor.net QA Contact: testopia@bugs.koha-community.org After enabling GoogleIpenIDConnect I am no longer able to left click the "Log in to your account" link on the top of the opac. The link is valid and works if you right click and open in a new tab. Quickly looking at the code this seems to be because the data-toggle attribute is set to modal. <a class="nav-link login-link" href="/cgi-bin/koha/svc/auth/googleopenidconnect" role="button" data-toggle="modal"><i class="fa fa-user fa-icon-black fa-fw" aria-hidden="true"></i> <span class="userlabel">Log in to your account</span></a> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28679 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook@prosentient.com.au -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28679 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28679 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|21.05 |unspecified Depends on| |20168 CC| |jonathan.druart+koha@gmail. | |com, oleonard@myacpl.org --- Comment #1 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Caused by ? commit 9cb89b46397efc5e288723829613c33e7eea0d69 Bug 20168: Update of the OPAC bootstrap template to bootstrap v4 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20168 [Bug 20168] Update of the OPAC bootstrap template to bootstrap v4 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28679 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |major -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28679 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28679 --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 122780 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122780&action=edit Bug 28679: Unable to click "Log in to your account" when GoogleOpenIDConnect is enabled This patch corrects the login link in the OPAC when GoogleOpenIDConnect is enabled. It removes modal-related markup which was causing the link to fail. To test, apply the patch and enable the GoogleOpenIDConnect system preference. - In the OPAC, click the "Log in to your account" link in the header. You should be redirected to a Google authentication form. - Disable the GoogleOpenIDConnect preference. The login link in the OPAC should trigger a modal login form. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28679 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28679 --- Comment #3 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 122928 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122928&action=edit Bug 28679: Unable to click "Log in to your account" when GoogleOpenIDConnect is enabled This patch corrects the login link in the OPAC when GoogleOpenIDConnect is enabled. It removes modal-related markup which was causing the link to fail. To test, apply the patch and enable the GoogleOpenIDConnect system preference. - In the OPAC, click the "Log in to your account" link in the header. You should be redirected to a Google authentication form. - Disable the GoogleOpenIDConnect preference. The login link in the OPAC should trigger a modal login form. Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28679 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com Attachment #122780|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28679 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28679 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122928|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 123159 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123159&action=edit Bug 28679: Unable to click "Log in to your account" when GoogleOpenIDConnect is enabled This patch corrects the login link in the OPAC when GoogleOpenIDConnect is enabled. It removes modal-related markup which was causing the link to fail. To test, apply the patch and enable the GoogleOpenIDConnect system preference. - In the OPAC, click the "Log in to your account" link in the header. You should be redirected to a Google authentication form. - Disable the GoogleOpenIDConnect preference. The login link in the OPAC should trigger a modal login form. Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28679 --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- The solution was also confirmed on the mailing list. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28679 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |21.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28679 --- Comment #6 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Pushed to master for 21.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28679 --- Comment #7 from Chad Billman <chad@pennmanor.net> --- Is it possible to get this merged into 21.05 as well? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28679 --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Chad Billman from comment #7)
Is it possible to get this merged into 21.05 as well?
This is marked as a "major" bug fix so chances are good, especially if you can confirm that the problem exists in 21.05 as well. The workflow is so that after this being pushed to master (what will be 21.11), the RMaint of the next lower version will check if it is needed and then so on. RMaints always have the final decision for their version. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28679 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_21_05_candidate -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28679 --- Comment #9 from Chad Billman <chad@pennmanor.net> --- I can confirm this bug is impacting our 21.05.01 installation. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28679 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|21.11.00 |21.11.00,21.05.03 released in| | --- Comment #10 from Kyle M Hall <kyle@bywatersolutions.com> --- Pushed to 21.05.x for 21.05.03 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28679 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m Version(s)|21.11.00,21.05.03 |21.11.00,21.05.03,20.11.09 released in| | Status|Pushed to stable |Pushed to oldstable --- Comment #11 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to 20.11.x for 20.11.09 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28679 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor@tuxayo.net Resolution|--- |FIXED Status|Pushed to oldstable |RESOLVED --- Comment #12 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Missing dependencies for 20.05.x, it shouldn't be affected, no backport. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28679 Bug 28679 depends on bug 20168, which changed state. Bug 20168 Summary: Update of the OPAC bootstrap template to bootstrap v4 https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20168 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28679 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |katrin.fischer@bsz-bw.de |y.org | CC| |tomascohen@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28679 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com Text to go in the| |This fixes the login link release notes| |in the OPAC when | |GoogleOpenIDConnect is | |enabled. It removes | |modal-related markup which | |was causing the link to | |fail. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28679 Mark Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtompset@hotmail.com --- Comment #13 from Mark Tompsett <mtompset@hotmail.com> --- I'm thankful this is already pushed, but I'm curious why was the role attribute removed as well? It was only the data-modal part that was preventing it. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28679 --- Comment #14 from Owen Leonard <oleonard@myacpl.org> --- (In reply to Mark Tompsett from comment #13)
I'm curious why was the role attribute removed as well?
When GoogleOpenIDConnect is enabled the link is a real link, not a trigger for something. "clickable elements that trigger a response when activated by the user." -- https://developer.mozilla.org/en-US/docs/Web/Accessibility/ARIA/Roles/button.... -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28679 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_21_05_candidate | -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org