[Bug 43174] New: Regressions: Staff interface patron search on a record details page - lists patrons by default
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43174 Bug ID: 43174 Summary: Regressions: Staff interface patron search on a record details page - lists patrons by default Initiative type: --- Sponsorship --- status: Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Hold requests Assignee: koha-bugs@lists.koha-community.org Reporter: david@davidnind.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, lisette@bywatersolutions.com, tomascohen@gmail.com Target Milestone: --- When placing holds in the staff interface the patron search lists the first 20 results by default - previously this did not happen. To reproduce: 1. Go to a record in the staff interface. 2. Click on "Place hold". 3. Give things a second. 4. Under the patron search input box, a list of patrons appear (first 20 results). -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43174 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |41604 --- Comment #1 from David Nind <david@davidnind.com> --- Regression caused by bug 41604 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41604 [Bug 41604] Impossible to hide Checkin column in issues-table in circ/circulation.pl -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43174 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |jonathan.druart@gmail.com |ity.org | Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43174 --- Comment #2 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 202582 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=202582&action=edit Bug 43174: Add a Cypress test -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43174 --- Comment #3 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 202583 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=202583&action=edit Bug 43174: Restore defer loading for patron searches On the hold request and the patron search pages, the search is not deferred when a state exists. Coming from commit 2a344136014250b205ff74d8ea2dcb679ebb7105 Bug 41604: Save user decision per column when visibility changes - if (default_save_state_search) { + if (default_save_state || default_save_state_search) { $("#" + settings.nTable.id).data("loaded_from_state", true); - } else { + } + if (!default_save_state_search) { delete state.search; state.columns.forEach(c => delete c.search); I think this was a leftover from another try to fix bug 41604. I don't see how it could help in the context of saving the user decision. In the different patches from bug 41604 we don't test loaded_from_state. Test plan: Go to /cgi-bin/koha/members/members-home.pl => The table is not displayed Search for patrons => The table is displayed Reload the page => Without this patch the table is displayed => With this patch the table is not displayed If you have "Save search state on page change" enabled for this table, the table should be displayed if a previous search was made. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43174 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |regression -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43174 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43174 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #202582|0 |1 is obsolete| | Attachment #202583|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43174 --- Comment #4 from David Nind <david@davidnind.com> --- Created attachment 202585 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=202585&action=edit Bug 43174: Add a Cypress test Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43174 --- Comment #5 from David Nind <david@davidnind.com> --- Created attachment 202586 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=202586&action=edit Bug 43174: Restore defer loading for patron searches On the hold request and the patron search pages, the search is not deferred when a state exists. Coming from commit 2a344136014250b205ff74d8ea2dcb679ebb7105 Bug 41604: Save user decision per column when visibility changes - if (default_save_state_search) { + if (default_save_state || default_save_state_search) { $("#" + settings.nTable.id).data("loaded_from_state", true); - } else { + } + if (!default_save_state_search) { delete state.search; state.columns.forEach(c => delete c.search); I think this was a leftover from another try to fix bug 41604. I don't see how it could help in the context of saving the user decision. In the different patches from bug 41604 we don't test loaded_from_state. Test plan: Go to /cgi-bin/koha/members/members-home.pl => The table is not displayed Search for patrons => The table is displayed Reload the page => Without this patch the table is displayed => With this patch the table is not displayed If you have "Save search state on page change" enabled for this table, the table should be displayed if a previous search was made. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43174 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrew@bywatersolutions.com --- Comment #6 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- *** Bug 43197 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43174 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |major -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43174 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Small patch QA Contact|testopia@bugs.koha-communit |paul.derscheid@lmscloud.de |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43174 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #202585|0 |1 is obsolete| | Attachment #202586|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43174 --- Comment #7 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Created attachment 202725 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=202725&action=edit Bug 43174: Add a Cypress test Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43174 --- Comment #8 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Created attachment 202726 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=202726&action=edit Bug 43174: Restore defer loading for patron searches On the hold request and the patron search pages, the search is not deferred when a state exists. Coming from commit 2a344136014250b205ff74d8ea2dcb679ebb7105 Bug 41604: Save user decision per column when visibility changes - if (default_save_state_search) { + if (default_save_state || default_save_state_search) { $("#" + settings.nTable.id).data("loaded_from_state", true); - } else { + } + if (!default_save_state_search) { delete state.search; state.columns.forEach(c => delete c.search); I think this was a leftover from another try to fix bug 41604. I don't see how it could help in the context of saving the user decision. In the different patches from bug 41604 we don't test loaded_from_state. Test plan: Go to /cgi-bin/koha/members/members-home.pl => The table is not displayed Search for patrons => The table is displayed Reload the page => Without this patch the table is displayed => With this patch the table is not displayed If you have "Save search state on page change" enabled for this table, the table should be displayed if a previous search was made. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43174 --- Comment #9 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Created attachment 202727 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=202727&action=edit Bug 43174: (QA follow-up) Restore user choices on redraw independent of search state To test: - cypress run --spec t/cypress/integration/KohaTable/PatronSearch_spec.ts - cypress run --spec t/cypress/integration/KohaTable/KohaTable_spec.ts Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43174 Pedro Amorim (ammopt) <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |26.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43174 --- Comment #10 from Pedro Amorim (ammopt) <pedro.amorim@openfifth.co.uk> --- Thanks everyone! Pushed to main for 26.11! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43174 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|26.11.00 |26.11.00,26.05.03 released in| | Status|Pushed to main |Pushed to stable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43174 --- Comment #11 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Nice work everyone! Pushed to 26.05.x for the upcoming 26.05.03 release. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43174 Blou <philippe.blouin@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hammat.wele@inlibro.com --- Comment #12 from Blou <philippe.blouin@inlibro.com> --- *** Bug 43323 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org