https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42915 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42915 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |regression -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42915 Brendan Lawlor <blawlor@clamsnet.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Sponsorship status|--- |Sponsored Assignee|koha-bugs@lists.koha-commun |blawlor@clamsnet.org |ity.org | Status|NEW |Needs Signoff Patch complexity|--- |Small patch Comma delimited| |CLAMS list of Sponsors| | --- Comment #1 from Brendan Lawlor <blawlor@clamsnet.org> --- I think this is the right approach, but it touches datatables.js so it could possibly have side effects in other tables. Please test filtering in other tables too. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42915 --- Comment #3 from Brendan Lawlor <blawlor@clamsnet.org> --- Created attachment 201100 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=201100&action=edit Bug 42915: Fix holds table filtering by pickup library name and branchcode This patch adds a searchValue attribute to the column definition for pickup library. The API needs the data attribute to be the library id, so this allows filtering by library name or branchcode. 1. Have holds on a bib for different patrons and pickup locations 2. Try filtering by a pickup library name or branchcode 3. See 'No matching records found' 4. Apply patch and repeat step 2 5. Filtering works! 6. Note: if two libraries share the same beginning text you get no results :( For example: Fairview and Fairfield, you need 5 characters Sponsored-by: CLAMS -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42915 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #201099|0 |1 is obsolete| | Attachment #201100|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42915 --- Comment #5 from David Nind <david@davidnind.com> --- Created attachment 201117 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=201117&action=edit Bug 42915: Fix holds table filtering by pickup library name and branchcode This patch adds a searchValue attribute to the column definition for pickup library. The API needs the data attribute to be the library id, so this allows filtering by library name or branchcode. 1. Have holds on a bib for different patrons and pickup locations 2. Try filtering by a pickup library name or branchcode 3. See 'No matching records found' 4. Apply patch and repeat step 2 5. Filtering works! 6. Note: if two libraries share the same beginning text you get no results :( For example: Fairview and Fairfield, you need 5 characters Sponsored-by: CLAMS Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42915 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |jonathan.druart@gmail.com --- Comment #6 from Jonathan Druart <jonathan.druart@gmail.com> --- You should not need to update datatables.js, everything is covered already. Why do you use searchData? Adjusting "data" should be enough. For the libraries, have a look at members/holdshistory.tt: datatype: "coded_value:library", dataFilter: "libraries", Let me know if you have any questions! -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42915 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #201298|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42915 Brendan Lawlor <blawlor@clamsnet.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42915 --- Comment #10 from Brendan Lawlor <blawlor@clamsnet.org> --- Created attachment 201320 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=201320&action=edit Bug 42915: Add patron names to data in column def in holds table This patch adds the patron firstname and surname to the searchable data in the patron column definition for the holds table and removes unnecessary code from the render function. This enables searching holds by patron names. To test: 1. Have holds on a bib for different patrons and pickup locations 2. Try filtering by a patron name 3. See 'No matching records found' 4. Apply patch and repeat step 2 5. Filtering by patron name works! 6. Confirm filtering by cardnumber still works too 7. Set system preference HidePatronName to 'Don't show' 8. Confirm searching by patron names continues to work :) Sponsored-by: CLAMS -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42915 Brendan Lawlor <blawlor@clamsnet.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #201117|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42915 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #11 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- (In reply to Brendan Lawlor from comment #10)

7. Set system preference HidePatronName to 'Don't show' 8. Confirm searching by patron names continues to work :)

I don't think this is the behavior we want. In testing I made a hold for Henry and a hold for Ronnie. When I set HidePatronName to 'Don't show,' a search for "Henry" on the holds table still filters the list down to only Henry's hold, even though I can no longer see his name. For a staff member that has access to the holds list but does not have access Henry's patron record, we've just revealed a name they should not have access to (albeit in a weird roundabout way). This is pretty niche and doesn't feel highly insecure, so I'm certainly open to being overruled. Other than this issue, everything worked as expected. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42915 Brendan Lawlor <blawlor@clamsnet.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42915 Brendan Lawlor <blawlor@clamsnet.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42915 --- Comment #13 from Brendan Lawlor <blawlor@clamsnet.org> --- Created attachment 201435 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=201435&action=edit Bug 42915: Use coded value for library filtering in holds table This patch adds coded_values for libraries to the holds table and sets the data type in the pickup library column definition. This enables searching holds by pickup location. 1. Have holds on a bib for different patrons and pickup locations 2. Try filtering by a pickup library name or branchcode 3. See 'No matching records found' 4. Apply patch and repeat step 2 5. Filtering works! 6. Note: if two libraries share the same beginning text both results are returned :) For example: 'Fair' returns holds for pickup at Fairview and Fairfield Sponsored-by: CLAMS -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42915 Brendan Lawlor <blawlor@clamsnet.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42915 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #201435|0 |1 is obsolete| | Attachment #201436|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42915 --- Comment #16 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 201446 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=201446&action=edit Bug 42915: Add patron names to data in column def in holds table This patch adds the patron firstname and surname to the searchable data in the patron column definition for the holds table and removes unnecessary code from the render function. This enables searching holds by patron names. To test: 1. Have holds on a bib for different patrons and pickup locations 2. Try filtering by a patron name 3. See 'No matching records found' 4. Apply patch and repeat step 2 5. Filtering by patron name works! 6. Confirm filtering by cardnumber still works too 7. Set system preference HidePatronName to 'Don't show' 8. Confirm searching by patron names doesn't work ;) Sponsored-by: CLAMS Signed-off-by: Andrew Fuerste Henry <andrew@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42915 --- Comment #18 from Jonathan Druart <jonathan.druart@gmail.com> --- [FAIL] koha-tmpl/intranet-tmpl/prog/en/includes/holds_table.inc SKIP filters FAIL valid_template : filter not found Missing [% USE raw %] -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42915 --- Comment #22 from Brendan Lawlor <blawlor@clamsnet.org> --- Created attachment 201876 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=201876&action=edit Bug 42915: (follow-up) Fix holds table display on patron record holds tab To test: 1. Have a patron with multiple holds 2. Go to the patron record's hold tab 3. Confirm the table loads and no errors are logged to the console Sponsored-by: CLAMS -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42915 --- Comment #20 from Brendan Lawlor <blawlor@clamsnet.org> --- Created attachment 201874 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=201874&action=edit Bug 42915: Use coded value for library filtering in holds table This patch adds coded_values for libraries to the holds table and sets the data type in the pickup library column definition. This enables searching holds by pickup location. 1. Have holds on a bib for different patrons and pickup locations 2. Try filtering by a pickup library name or branchcode 3. See 'No matching records found' 4. Apply patch and repeat step 2 5. Filtering works! 6. Note: if two libraries share the same beginning text both results are returned :) For example: 'Fair' returns holds for pickup at Fairview and Fairfield Sponsored-by: CLAMS Signed-off-by: Andrew Fuerste Henry <andrew@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42915 Brendan Lawlor <blawlor@clamsnet.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #19 from Brendan Lawlor <blawlor@clamsnet.org> --- Thanks, Joubu! I added the missing filter and also fixed an issue with the table not loading on the patron record holds tab. I also made sure to test the holds to pull and holds awaiting pickup tables. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42915 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #201874|0 |1 is obsolete| | Attachment #201875|0 |1 is obsolete| | Attachment #201876|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42915 --- Comment #24 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 201918 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=201918&action=edit Bug 42915: Add patron names to data in column def in holds table This patch adds the patron firstname and surname to the searchable data in the patron column definition for the holds table and removes unnecessary code from the render function. This enables searching holds by patron names. To test: 1. Have holds on a bib for different patrons and pickup locations 2. Try filtering by a patron name 3. See 'No matching records found' 4. Apply patch and repeat step 2 5. Filtering by patron name works! 6. Confirm filtering by cardnumber still works too 7. Set system preference HidePatronName to 'Don't show' 8. Confirm searching by patron names doesn't work ;) Sponsored-by: CLAMS Signed-off-by: Andrew Fuerste Henry <andrew@bywatersolutions.com> Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42915 --- Comment #26 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 201920 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=201920&action=edit Bug 42915: (QA follow-up) Declare all_libraries once, unconditionally, in request.tt holds_table.inc is INCLUDEd in a loop from reserve/request.tt whenever HoldsSplitQueue splits the holds queue by branch/itemtype, or when holds for more than one biblio are shown at once (multi_hold). Each inclusion appended its own <script> block declaring `all_libraries`, and since top-level `let`/`const` in separate inline <script> tags share the page's global lexical scope, the second and subsequent occurrences threw "Identifier 'all_libraries' has already been declared", breaking those script blocks and the pickup-library filtering that depends on `all_libraries` being set. Worse, that script block is only emitted when a biblio's holds are actually rendered (biblioloo.total_holds > 0), but holds.js is loaded unconditionally by reserve/request.tt and reads `all_libraries` at top-level parse time. Placing the very first hold on a title (0 existing holds) therefore threw: ReferenceError: all_libraries is not defined breaking every hold-management handler defined below that line in holds.js. Fix both by declaring `all_libraries` exactly once, unconditionally, in request.tt's existing page-global script block (alongside the other unconditional globals such as HidePatronName and HoldsSplitQueue), before Asset.js("js/holds.js") loads, instead of duplicating it inside the per-title/per-split holds_table.inc include. To test: 1. Search for a title with no existing holds and start placing one 2. Without this patch: browser console shows "ReferenceError: all_libraries is not defined" as soon as the page loads 3. With this patch: no console errors 4. Set HoldsSplitQueue to "pickup library", place holds on a title for two different pickup libraries, confirm both split tables render with working patron-name and pickup-library filtering and no console errors 5. Confirm the patron's own Holds tab (moremember.pl/circulation.pl) still loads without console errors -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42915 --- Comment #28 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 201922 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=201922&action=edit Bug 42915: (QA follow-up) Remove unused filters_options variable filters_options was introduced with the coded_values library filtering patch but never referenced anywhere in the file. Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.