https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40961 --- Comment #2 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 187489 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=187489&action=edit Bug 40961: Fix query for localuse -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40961 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrew@bywatersolutions.com --- Comment #4 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- This is sort of a weird issue. If one records local use via checkin with the RecordLocalUseOnReturn syspref, those localuse entries will always lack a borrowernumber and therefor have a NULL for patron's home library. That means they won't come up in any query made via the wizard that selects a value for patron's home library. But if one records local use via a statistical patron, then there will be an associated borrowernumber and therefore a patron home library and folks may want to filter their results based on that value. Prior to Bug 20601, the patron library dropdown in the wizard didn't work and therefore didn't impact these queries. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40961 --- Comment #6 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- I don't think Lucas's original fix here is the way to go. He told the query to ignore both the associated borrower's branch and the associated item's homebranch. If a library is using statistical patrons, the borrower's branch will have a value that libraries may want to use for differentiating local use counts. The item's homebranch should always have an item, even if the item has been deleted. In the circulation statistics wizard the various library values correspond to: Issuing library - the value record in statistics.branch when the transaction took place Home library - the current home library of the item in question Holding library - the current holding library of the item in question Patron library - the current library of the associated patron used (if any - for local use there is only a patron if statistical patrons are used) So if the user lands on the circulation statistics page, changes Type to "Local use" and runs the query with the default values they get all local uses that happened at the logged-in branch, involving items with home and holding values matching the logged-in branch, and to patrons from the logged-in branch. That's a very specific query and seems unlikely to match what folks want. I suggest we make the page load with home library, holding library, and patron library all set to blank. That would make the default search simply all transactions of the given type that happened at the logged-in branch. Broad but clear. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40961 --- Comment #7 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 189715 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=189715&action=edit Bug 40961: Default item and patron library values to blank To test: 1 - load the Circulation Statistics wizard 2 - confirm Home library, Holding library, and Patron library default to selecting the logged-in branch 3 - apply patch, restart_all, reload page 4 - confirm Home library, Holding library, and Patron library default to a blank selection 5 - confirm queries with those blank selections are not limited by items.homebranch, items.holdingbranch, or borrowers.branchcode -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40961 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #187489|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40961 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #189715|0 |1 is obsolete| | --- Comment #8 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 189869 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=189869&action=edit Bug 40961: Default item and patron library values to blank To test: 1 - load the Circulation Statistics wizard 2 - confirm Home library, Holding library, and Patron library default to selecting the logged-in branch 3 - apply patch, restart_all, reload page 4 - confirm Home library, Holding library, and Patron library default to a blank selection 5 - confirm queries with those blank selections are not limited by items.homebranch, items.holdingbranch, or borrowers.branchcode Signed-off-by: Katherine Wolf <wolf@sarsf.org> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40961 --- Comment #10 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- (In reply to Marcel de Rooy from comment #9)

Since this script is not only about LocalUse, I actually do not understand why we are clearing all those fields for anyone here.

In Discussion

Looking at the other statistics wizards, we are inconsistent about when we set a default library for queries and when we do not. These changes make the Circulation wizard consistent with the Holds wizard, where we set a default value for Pickup library but not for item home or holding branch. To me, it seems most clear to the user to default to a broad query and allow the user to make it more specific as desired. This rationale applies to queries for checkouts, renewals, and checkins as well as local use. This bug was originally filed because users from several libraries found the current default query confusing and undesirable. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40961 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|In Discussion |Passed QA -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40961 --- Comment #12 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Andrew Fuerste-Henry from comment #10)

(In reply to Marcel de Rooy from comment #9)

...

Since this script is not only about LocalUse, I actually do not understand why we are clearing all those fields for anyone here.

In Discussion

Looking at the other statistics wizards, we are inconsistent about when we set a default library for queries and when we do not. These changes make the Circulation wizard consistent with the Holds wizard, where we set a default value for Pickup library but not for item home or holding branch.

To me, it seems most clear to the user to default to a broad query and allow the user to make it more specific as desired. This rationale applies to queries for checkouts, renewals, and checkins as well as local use. This bug was originally filed because users from several libraries found the current default query confusing and undesirable.

Sounds fair to me given inconsistencies. Passing QA. See what happens :) -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40961 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |25.11.00 released in| | Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40961 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|25.11.00 |25.11.00,25.05.06 released in| | Status|Pushed to main |Pushed to stable -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40961 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable CC| |fridolin.somers@biblibre.co | |m Version(s)|25.11.00,25.05.06 |25.11.00,25.05.06,24.11.11 released in| | --- Comment #15 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to 24.11.x for 24.11.11 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40961 Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldstable |Needs documenting CC| |wainuiwitikapark@catalyst.n | |et.nz --- Comment #16 from Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> --- Not backporting to 22.11 -- You are receiving this mail because: You are watching all bug changes.