[Bug 39985] New: items.onloan field is not updated when an item is recalled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39985 Bug ID: 39985 Summary: items.onloan field is not updated when an item is recalled Change sponsored?: --- Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Notices Assignee: koha-bugs@lists.koha-community.org Reporter: emily.lamancusa@montgomerycountymd.gov QA Contact: testopia@bugs.koha-community.org Depends on: 19532 When an item is recalled, if the due date on the item should be updated due to the recall, only the issues.date_due field gets updated. The due date stored in items.onloan remains unchanged. To replicate: 1. Enable UseRecalls syspref and set corresponding circulation rules: - Recalls allowed - Recalls per record - On shelf recalls allowed - set to "If any unavailable" - Recall due date interval - set to 1 - Recall pickup period 2. Check out an item to a patron 3. Log into the OPAC as another patron 4. Search for the item checked out in step 2 5. Place a recall on that item 6. Search for that item in the staff interface => Note that the item status says, "Checked out to <patron>: due <tomorrow>" 7. Create the following SQL report in the reports module, using the barcode of the item that was recalled: SELECT onloan FROM items WHERE barcode='xxxxxxxxx' 8. Run the report => The onloan value is still set to the item's original due date, not the update due date of tomorrow Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 [Bug 19532] Recalls for Koha -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39985 Bug 39985 depends on bug 19532, which changed state. Bug 19532 Summary: Recalls for Koha https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39985 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |aleisha@catalyst.net.nz Change sponsored?|--- |Sponsored Assignee|koha-bugs@lists.koha-commun |aleisha@catalyst.net.nz |ity.org | Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39985 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39985 --- Comment #1 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 183875 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=183875&action=edit Bug 39985: Set items.onloan when recall adjusts checkout due date This enhancement ensures the due date stored in items.onloan is changed when a recall causes a checkout due date to change. To test: 1. Enable UseRecalls syspref and set corresponding circulation rules: - Recalls allowed - Recalls per record - On shelf recalls allowed - set to "If any unavailable" - Recall due date interval - set to 1 - Recall pickup period 2. Check out an item to a patron (Patron A) 2a. Make sure this patron has a primary email address set 2b. Check the patron's messaging preferences - make sure this patron has the 'Email' checkbox checked for the 'Return recalled item' notice 3. Go to Tools -> Notices & slips and find the RETURN_RECALLED_ITEM notice. In the Email notice, change "[% checkout.date_due | $KohaDates %]" to "[% item.onloan | $KohaDates %]" and Save. 4. Log into the OPAC as another patron 5. Search for the item checked out in step 2, and place a recall on that item 6. Search for that item in the staff interface => Note that the item status says, "Checked out to <patron>: due <tomorrow>" 7. Create the following SQL report in the reports module, using the barcode of the item that was recalled: SELECT onloan FROM items WHERE barcode='xxxxxxxxx' 8. Run the report => The onloan value is still set to the item's original due date, not the updated due date of tomorrow 9. Go to Patron A's account again and view their Notices tab. Click on the 'Notification to return a recalled item' => The original due date is used in the notice. 10. Apply the patch and restart services 11. Reset to run the tests again: - Check in the item, but do not confirm the recall in the pop-up - Go to the biblio detail page and cancel the recall 12. Repeat steps 2 to 5. 13. Run your report again (step 8) => The onloan value should now show the updated due date of tomorrow 14. View Patron A's latest 'Notification to return a recalled item' notice (step 9) => The updated due date should be used in the notice. 15. Confirm tests pass - t/db_dependent/Koha/Recalls.t Sponsored-by: Auckland University of Technology -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39985 Brendan Gallagher <brendan@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39985 Brendan Gallagher <brendan@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #183875|0 |1 is obsolete| | --- Comment #2 from Brendan Gallagher <brendan@bywatersolutions.com> --- Created attachment 189888 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=189888&action=edit Bug 39985: Set items.onloan when recall adjusts checkout due date This enhancement ensures the due date stored in items.onloan is changed when a recall causes a checkout due date to change. To test: 1. Enable UseRecalls syspref and set corresponding circulation rules: - Recalls allowed - Recalls per record - On shelf recalls allowed - set to "If any unavailable" - Recall due date interval - set to 1 - Recall pickup period 2. Check out an item to a patron (Patron A) 2a. Make sure this patron has a primary email address set 2b. Check the patron's messaging preferences - make sure this patron has the 'Email' checkbox checked for the 'Return recalled item' notice 3. Go to Tools -> Notices & slips and find the RETURN_RECALLED_ITEM notice. In the Email notice, change "[% checkout.date_due | $KohaDates %]" to "[% item.onloan | $KohaDates %]" and Save. 4. Log into the OPAC as another patron 5. Search for the item checked out in step 2, and place a recall on that item 6. Search for that item in the staff interface => Note that the item status says, "Checked out to <patron>: due <tomorrow>" 7. Create the following SQL report in the reports module, using the barcode of the item that was recalled: SELECT onloan FROM items WHERE barcode='xxxxxxxxx' 8. Run the report => The onloan value is still set to the item's original due date, not the updated due date of tomorrow 9. Go to Patron A's account again and view their Notices tab. Click on the 'Notification to return a recalled item' => The original due date is used in the notice. 10. Apply the patch and restart services 11. Reset to run the tests again: - Check in the item, but do not confirm the recall in the pop-up - Go to the biblio detail page and cancel the recall 12. Repeat steps 2 to 5. 13. Run your report again (step 8) => The onloan value should now show the updated due date of tomorrow 14. View Patron A's latest 'Notification to return a recalled item' notice (step 9) => The updated due date should be used in the notice. 15. Confirm tests pass - t/db_dependent/Koha/Recalls.t Sponsored-by: Auckland University of Technology Signed-off-by: Brendan Gallagher <brendan@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39985 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39985 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #189888|0 |1 is obsolete| | --- Comment #3 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 190017 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=190017&action=edit Bug 39985: Set items.onloan when recall adjusts checkout due date This enhancement ensures the due date stored in items.onloan is changed when a recall causes a checkout due date to change. To test: 1. Enable UseRecalls syspref and set corresponding circulation rules: - Recalls allowed - Recalls per record - On shelf recalls allowed - set to "If any unavailable" - Recall due date interval - set to 1 - Recall pickup period 2. Check out an item to a patron (Patron A) 2a. Make sure this patron has a primary email address set 2b. Check the patron's messaging preferences - make sure this patron has the 'Email' checkbox checked for the 'Return recalled item' notice 3. Go to Tools -> Notices & slips and find the RETURN_RECALLED_ITEM notice. In the Email notice, change "[% checkout.date_due | $KohaDates %]" to "[% item.onloan | $KohaDates %]" and Save. 4. Log into the OPAC as another patron 5. Search for the item checked out in step 2, and place a recall on that item 6. Search for that item in the staff interface => Note that the item status says, "Checked out to <patron>: due <tomorrow>" 7. Create the following SQL report in the reports module, using the barcode of the item that was recalled: SELECT onloan FROM items WHERE barcode='xxxxxxxxx' 8. Run the report => The onloan value is still set to the item's original due date, not the updated due date of tomorrow 9. Go to Patron A's account again and view their Notices tab. Click on the 'Notification to return a recalled item' => The original due date is used in the notice. 10. Apply the patch and restart services 11. Reset to run the tests again: - Check in the item, but do not confirm the recall in the pop-up - Go to the biblio detail page and cancel the recall 12. Repeat steps 2 to 5. 13. Run your report again (step 8) => The onloan value should now show the updated due date of tomorrow 14. View Patron A's latest 'Notification to return a recalled item' notice (step 9) => The updated due date should be used in the notice. 15. Confirm tests pass - t/db_dependent/Koha/Recalls.t Sponsored-by: Auckland University of Technology Signed-off-by: Brendan Gallagher <brendan@bywatersolutions.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39985 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |m.de.rooy@rijksmuseum.nl |y.org | CC| |m.de.rooy@rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39985 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |25.11.00 released in| | Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39985 --- Comment #4 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Nice work everyone! Pushed to main for 25.11 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39985 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|25.11.00 |25.11.00,25.05.06 released in| | Status|Pushed to main |Pushed to stable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39985 --- Comment #5 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Nice work everyone! Pushed to 25.05.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39985 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|25.11.00,25.05.06 |25.11.00,25.05.06,24.11.11 released in| | Status|Pushed to stable |Pushed to oldstable CC| |fridolin.somers@biblibre.co | |m --- Comment #6 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to 24.11.x for 24.11.11 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39985 Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |wainuiwitikapark@catalyst.n | |et.nz Status|Pushed to oldstable |Needs documenting --- Comment #7 from Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> --- Not backporting to 22.11 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org