[Bug 13686] New: Add a hint about collation to the "alphabet" syspref
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13686 Bug ID: 13686 Summary: Add a hint about collation to the "alphabet" syspref Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: I18N/L10N Assignee: koha-bugs@lists.koha-community.org Reporter: viktor.sarge@regionhalland.se QA Contact: testopia@bugs.koha-community.org CC: frederic@tamil.fr Today it's possible to define your own alphabet in the I18N/L10N preferences. This shows up in members-home.pl and lets you browse patrons. If you define an alphabet outside of the A-Z comfort zone (as in swedish with additional characters Å,Ä,Ö at the end) then the browsing will mix together for example Å,Ä,A and only view the additional letters as diacritics. A quick solution is to change the collation in the database but there is nothing in the syspref explaining this. My ambition here is to give users a quick hint that this can be done. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13686 Viktor Sarge <viktor.sarge@regionhalland.se> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13686 --- Comment #1 from Viktor Sarge <viktor.sarge@regionhalland.se> --- Created attachment 35778 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35778&action=edit Bug 13686 Add a hint about collation to the "alphabet" syspref This patch adds a quick hint in the "alphabet" syspref about the use of collation in the database to make browsing by surname work with alphabets outside of the A-Z range. Test plan: * Look at the "alphabet" syspref. * Install the patch and verify that the additional info about the use of collation is showing up in the "alphabet" syspref. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13686 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron@veron.ch --- Comment #2 from Marc Véron <veron@veron.ch> --- Hi Viktor, The text does not display at all, only the form field is visible. Reason: The text contains a colon (:), that breaks the display. Solution: Put the text in quotes. Marc -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13686 --- Comment #3 from Viktor Sarge <viktor.sarge@regionhalland.se> --- Created attachment 35817 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35817&action=edit Bug 13686 Add a hint about collation to the alphabet syspref This patch adds a quick hint in the "alphabet" syspref about the use of collation in the database to make browsing by surname work with alphabets outside of the A-Z range. Test plan: * Look at the "alphabet" syspref. * Install the patch and verify that the additional info about the use of collation is showing up in the "alphabet" syspref. This patch is hopefully also working - thanks Marc! Guess it goes to prove that no patch is too small to test properly before posting. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13686 --- Comment #4 from Viktor Sarge <viktor.sarge@regionhalland.se> --- I also learned not to put anything outside of A-Z in the commit messages. Had to learn how to use --amend in git :) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13686 Viktor Sarge <viktor.sarge@regionhalland.se> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |viktor.sarge@regionhalland. |ity.org |se -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13686 Viktor Sarge <viktor.sarge@regionhalland.se> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35778|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13686 --- Comment #5 from Marc Véron <veron@veron.ch> --- Hi Viktor, You can put qoutes around the whole text and leave the colon (:) in it: - "for lists of browsable letters. This should be a space separated list of uppercase letters. Hint: Changing collation in the database for the surname column of members is helpful to make browsing by last name work in members-home.pl when using an alphabet outside of A-Z." -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13686 Viktor Sarge <viktor.sarge@regionhalland.se> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35817|0 |1 is obsolete| | --- Comment #6 from Viktor Sarge <viktor.sarge@regionhalland.se> --- Created attachment 35821 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35821&action=edit Bug 13686 Add a hint about collation to the alphabet syspref This patch adds a quick hint in the "alphabet" syspref about the use of collation in the database to make browsing by surname work with alphabets outside of the A-Z range. Test plan: * Look at the "alphabet" syspref. * Install the patch and verify that the additional info about the use of collation is showing up in the "alphabet" syspref. Third times a charm hopefully :) This patch reintroduces the colon in "Hint:" and also corrects a weird wordning. Thanks Marc! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13686 --- Comment #7 from Marc Véron <veron@veron.ch> --- Hi Viktor, This patch seems to be on top of the first (obsoleted) patch and does not apply. I think the best way to resolve is to obsolete this latest patch and reactivate the very first patch. Then add the double quotes, do git add for the changed file and then do git commit --amend -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13686 Viktor Sarge <viktor.sarge@regionhalland.se> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35821|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13686 Viktor Sarge <viktor.sarge@regionhalland.se> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35778|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13686 --- Comment #8 from Viktor Sarge <viktor.sarge@regionhalland.se> --- Created attachment 35825 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35825&action=edit Bug 13686 Add a hint about collation to the alphabet syspref This patch adds a quick hint in the "alphabet" syspref about the use of collation in the database to make browsing by surname work with alphabets outside of the A-Z range. Test plan: * Look at the "alphabet" syspref. * Install the patch and verify that the additional info about the use of collation is showing up in the "alphabet" syspref. Trying to follow Marcs instructions on how to wrestle Git into posting the corrected patch. Fingers crossed.. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13686 --- Comment #9 from Viktor Sarge <viktor.sarge@regionhalland.se> --- Hm. When applying the patch on a new branch with git bz after having marked the first one as active and run --amend it still wants to apply both patches. Using interactive mode I tried to get attachment 35825 but that only messed up things with markup code in the .pref file. Will try to deactivate the first one again and hopefully leave 35825 applicable. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13686 Viktor Sarge <viktor.sarge@regionhalland.se> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35778|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13686 Viktor Sarge <viktor.sarge@regionhalland.se> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35825|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13686 Magnus Enger <magnus@enger.priv.no> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |magnus@enger.priv.no Status|Needs Signoff |ASSIGNED --- Comment #10 from Magnus Enger <magnus@enger.priv.no> --- No patches to sign off at the moment. Viktor: Maybe do a new patch from scratch? :-) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13686 Viktor Sarge <viktor.sarge@regionhalland.se> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13686 --- Comment #11 from Viktor Sarge <viktor.sarge@regionhalland.se> --- Created attachment 35956 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35956&action=edit Bug 13686 Add a hint about collation to the alphabet syspref New attempt from a fresh branch. Test plan: * Look at the alphabet syspref. * Install the patch. * Look again at the alphabet syspref and you should see a short hint about collation. Thanks for the patience - I already learned a few new things about Git with this patch. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13686 --- Comment #12 from Viktor Sarge <viktor.sarge@regionhalland.se> --- Ok - new attempt from a new branch after cleaning out my entire local Git. I don't have very high hopes, but it looks ok and seem to apply without complaints now. Fingers crossed and thanks for the patience. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13686 --- Comment #13 from Marc Véron <veron@veron.ch> --- Created attachment 35958 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35958&action=edit [Signed-off] Bug 13686 Add a hint about collation to the alphabet syspref New attempt from a fresh branch. Test plan: * Look at the alphabet syspref. * Install the patch. * Look again at the alphabet syspref and you should see a short hint about collation. Thanks for the patience - I already learned a few new things about Git with this patch. Text appears as expected. Signed-off-by: Marc Véron <veron@veron.ch> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13686 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |String patch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13686 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35956|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13686 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13686 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35958|0 |1 is obsolete| | --- Comment #14 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 36038 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36038&action=edit Bug 13686 Add a hint about collation to the alphabet syspref New attempt from a fresh branch. Test plan: * Look at the alphabet syspref. * Install the patch. * Look again at the alphabet syspref and you should see a short hint about collation. Thanks for the patience - I already learned a few new things about Git with this patch. Text appears as expected. Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> Amended patch: add a br tag -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13686 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@biblibre.co | |m --- Comment #15 from Jonathan Druart <jonathan.druart@biblibre.com> --- oleonard: Joubu: I suggest "Changing collation in the database for the 'surname' column of the 'borrowers' table is helpful to make browsing by last name work in members-home.pl when using an alphabet outside of A-Z" oleonard: I don't like referring to "members-home.pl" but I don't know a better way to say it. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13686 --- Comment #16 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 36040 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36040&action=edit Bug 13686: Change wording Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13686 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen@gmail.com --- Comment #17 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Patches pushed to master. Thanks Viktor! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13686 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |chris@bigballofwax.co.nz --- Comment #18 from Chris Cormack <chris@bigballofwax.co.nz> --- Pushed to 3.18.x will be in 3.18.6 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org