[Bug 6820] New: hide receive option if there is nothing to receive
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6820 Bug #: 6820 Summary: hide receive option if there is nothing to receive Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Platform: All OS/Version: All Status: NEW Severity: minor Priority: P5 Component: Acquisitions AssignedTo: henridamien@koha-fr.org ReportedBy: nengard@gmail.com QAContact: koha-bugs@lists.koha-community.org Created attachment 5227 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=5227 vendor search Maybe we should hide the receive shipment link on the vendor search if there is nothing to receive - or rename it to say 'received shipments' since that's what you see when you go there. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6820 Samuel Crosby <scrosby000@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |scrosby000@gmail.com --- Comment #1 from Samuel Crosby <scrosby000@gmail.com> --- Created attachment 23920 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23920&action=edit Potential bug fix Just put the receive button creation in an if statement. Check the commit message for testing instructions. -- You are receiving this mail because: You are the QA Contact for the bug. You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6820 Samuel Crosby <scrosby000@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |scrosby000@gmail.com |ity.org | -- You are receiving this mail because: You are the QA Contact for the bug. You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6820 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6820 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23920|0 |1 is obsolete| | --- Comment #2 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 37296 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37296&action=edit Bug 6820 - hide receive option if there is nothing to receive The "receive shipment" button appears even if there are no orders to receive. This patch hides the button if there are no orders. To test the patch: 1. Go to "aquisitions" 2. Create a vendor 3. As the newly created vendor has no orders, there will now be no "receive shipment" button 4. Create a basket 5. Go back to the vendor search 6. The button should now appear for that vendor I've also tested it with a mix of vendors with and without baskets in the same search. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6820 --- Comment #3 from Marc Véron <veron@veron.ch> --- Created attachment 37318 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37318&action=edit [Signed-off] Bug 6820 - hide receive option if there is nothing to receive The "receive shipment" button appears even if there are no orders to receive. This patch hides the button if there are no orders. To test the patch: 1. Go to "aquisitions" 2. Create a vendor 3. As the newly created vendor has no orders, there will now be no "receive shipment" button 4. Create a basket 5. Go back to the vendor search 6. The button should now appear for that vendor I've also tested it with a mix of vendors with and without baskets in the same search. Followed test plan, works as expected. Signed-off-by: Marc Véron <veron@veron.ch> -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6820 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron@veron.ch Attachment #37296|0 |1 is obsolete| | -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6820 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6820 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6820 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37318|0 |1 is obsolete| | --- Comment #4 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 37339 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37339&action=edit [PASSED QA] Bug 6820 - hide receive option if there is nothing to receive The "receive shipment" button appears even if there are no orders to receive. This patch hides the button if there are no orders. To test the patch: 1. Go to "aquisitions" 2. Create a vendor 3. As the newly created vendor has no orders, there will now be no "receive shipment" button 4. Create a basket 5. Go back to the vendor search 6. The button should now appear for that vendor I've also tested it with a mix of vendors with and without baskets in the same search. Followed test plan, works as expected. Signed-off-by: Marc Veron <veron@veron.ch> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6820 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen@gmail.com --- Comment #5 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Patch pushed to master. Thanks Samuel! -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6820 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris@bigballofwax.co.nz Severity|minor |enhancement -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org