[Bug 9353] New: Missing subfields on MARC21 frameworks
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9353 Bug ID: 9353 Summary: Missing subfields on MARC21 frameworks Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Cataloging Assignee: bgkriegel@gmail.com Reporter: bgkriegel@gmail.com CC: m.de.rooy@rijksmuseum.nl MARC fields 029, 863, 864 and 865 don't have corresponding subfields on default and example MARC21 frameworks -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9353 --- Comment #1 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Created attachment 14440 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14440&action=edit Bug 9353 - Missing subfields on MARC21 frameworks This patch adds missing subfields on MARC fields 029abct (http://www.oclc.org/bibformats/en/0xx/029.shtm) 863abcdefghijklmnopqstvwxz68 (same for 864/5) (http://www.loc.gov/marc/holdings/hd863865.html) To test: 1) dev master system with default and example MARC21 frameworks 2) Go to Home > Administration > MARC frameworks 3) Click on 'MARC structure' of any framework 4) Search for tag 029 (or 863/4/5) 5) Click 'Subfields', there are none. 6) Apply the patch 7) Replace old frameworks, easiest by command line: mysql -uuser -ppass kohadb -e 'delete from biblio_framework; delete from marc_tag_structure; delete from marc_subfield_structure' mysql -uuser -ppass kohadb < installer/data/mysql/en/marcflavour/marc21/mandatory/marc21_framework_DEFAULT.sql mysql -uuser -ppass kohadb < installer/data/mysql/en/marcflavour/marc21/optional/marc21_simple_bib_frameworks.sql 8) Repeat steps 2-4 9) Click 'Subfields', now they are. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9353 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9353 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nengard@gmail.com --- Comment #2 from Nicole C. Engard <nengard@gmail.com> --- Note that this only seems to apply for new installs - I don't see updatedatabase.pl file in the patch. Is that right? Nicole -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9353 --- Comment #3 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- (In reply to comment #2)
Note that this only seems to apply for new installs - I don't see updatedatabase.pl file in the patch. Is that right?
Yes, you are right. I'll look how to do that. Bernardo -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9353 --- Comment #4 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Created attachment 14532 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14532&action=edit Followup Bug 9353: Missing subfields on MARC21 frameworks This followup changes updatedatabase.pl. Only touch frameworks that have the missing subfields. If both patches are applied, the test plan changes. To test: 1) dev master system with default and example MARC21 frameworks 2) Go to Home > Administration > MARC frameworks 3) Click on 'MARC structure' of any framework 4) Search for tag 029 (or 863/4/5) 5) Click 'Subfields', there are none. 6) Apply both patches 7) run 'perl installer/data/mysql/updatedatabase.pl' 8) Repeat steps 2-4 9) Click 'Subfields', now they are. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9353 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #14440|0 |1 is obsolete| | --- Comment #5 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 14699 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14699&action=edit Bug 9353 - Missing subfields on MARC21 frameworks This patch adds missing subfields on MARC fields 029abct (http://www.oclc.org/bibformats/en/0xx/029.shtm) 863abcdefghijklmnopqstvwxz68 (same for 864/5) (http://www.loc.gov/marc/holdings/hd863865.html) To test: 1) dev master system with default and example MARC21 frameworks 2) Go to Home > Administration > MARC frameworks 3) Click on 'MARC structure' of any framework 4) Search for tag 029 (or 863/4/5) 5) Click 'Subfields', there are none. 6) Apply the patch 7) Replace old frameworks, easiest by command line: mysql -uuser -ppass kohadb -e 'delete from biblio_framework; delete from marc_tag_structure; delete from marc_subfield_structure' mysql -uuser -ppass kohadb < installer/data/mysql/en/marcflavour/marc21/mandatory/marc21_framework_DEFAULT.sql mysql -uuser -ppass kohadb < installer/data/mysql/en/marcflavour/marc21/optional/marc21_simple_bib_frameworks.sql 8) Repeat steps 2-4 9) Click 'Subfields', now they are. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9353 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #14532|0 |1 is obsolete| | --- Comment #6 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 14700 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14700&action=edit Followup Bug 9353: Missing subfields on MARC21 frameworks This followup changes updatedatabase.pl. Only touch frameworks that have the missing subfields. If both patches are applied, the test plan changes. To test: 1) dev master system with default and example MARC21 frameworks 2) Go to Home > Administration > MARC frameworks 3) Click on 'MARC structure' of any framework 4) Search for tag 029 (or 863/4/5) 5) Click 'Subfields', there are none. 6) Apply both patches 7) run 'perl installer/data/mysql/updatedatabase.pl' 8) Repeat steps 2-4 9) Click 'Subfields', now they are. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9353 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |kyle@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9353 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |paul.poulain@biblibre.com QA Contact| |katrin.fischer@bsz-bw.de -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9353 --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Bernardo, could you provide a follow-up (maybe on a separate bug) for the fast add framework? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9353 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9353 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #14699|0 |1 is obsolete| | Attachment #14700|0 |1 is obsolete| | --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 16466 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=16466&action=edit [PASSED QA] Bug 9353 - Missing subfields on MARC21 frameworks This patch adds missing subfields on MARC fields 029abct (http://www.oclc.org/bibformats/en/0xx/029.shtm) 863abcdefghijklmnopqstvwxz68 (same for 864/5) (http://www.loc.gov/marc/holdings/hd863865.html) To test: 1) dev master system with default and example MARC21 frameworks 2) Go to Home > Administration > MARC frameworks 3) Click on 'MARC structure' of any framework 4) Search for tag 029 (or 863/4/5) 5) Click 'Subfields', there are none. 6) Apply the patch 7) Replace old frameworks, easiest by command line: mysql -uuser -ppass kohadb -e 'delete from biblio_framework; delete from marc_tag_structure; delete from marc_subfield_structure' mysql -uuser -ppass kohadb < installer/data/mysql/en/marcflavour/marc21/mandatory/marc21_framework_DEFAULT.sql mysql -uuser -ppass kohadb < installer/data/mysql/en/marcflavour/marc21/optional/marc21_simple_bib_frameworks.sql 8) Repeat steps 2-4 9) Click 'Subfields', now they are. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Updated frameworks are ok. Note: Only en frameworks are updated, so if other languages need those fields too, we need some followups. Also Fast Add framework is missing. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9353 --- Comment #9 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 16467 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=16467&action=edit [PASSED QA] Followup Bug 9353: Missing subfields on MARC21 frameworks This followup changes updatedatabase.pl. Only touch frameworks that have the missing subfields. If both patches are applied, the test plan changes. To test: 1) dev master system with default and example MARC21 frameworks 2) Go to Home > Administration > MARC frameworks 3) Click on 'MARC structure' of any framework 4) Search for tag 029 (or 863/4/5) 5) Click 'Subfields', there are none. 6) Apply both patches 7) run 'perl installer/data/mysql/updatedatabase.pl' 8) Repeat steps 2-4 9) Click 'Subfields', now they are. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Update works nicely. Checked various frameworks and results were ok. Also new fields are hidden. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9353 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #10 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- This patch has been pushed to master. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9353 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9353 --- Comment #11 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Needed for Bug 5858 Pushed to 3.10.x, will be in 3.10.10 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9353 Chris Hall <chrish@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chrish@catalyst.net.nz --- Comment #12 from Chris Hall <chrish@catalyst.net.nz> --- Pushed to 3.8.x, will be in 3.8.18 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org