http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5858 --- Comment #2 from Jared Camins-Esakov <jcamins@cpbibliography.com> 2011-03-13 15:29:09 UTC --- Subfields that are probably missing (I did not check all these subfields in the default frameworks, but I thought the list of new subfields might be of use to someone, even unproofed): 015 $z - Canceled/Invalid national bibliography number (National bibliography number) 017 $z - Canceled/Invalid Copyright or Legal Deposit Number (Copyright or Legal Deposit Number) 022 $l - ISSN-L (ISSN) 022 $m - Canceled ISSN-L (ISSN) 033 $0 - Record control number (R) (Date/Time and Place of an Event) 033 $2 - Source of term (R) (Date/Time and Place of an Event) 033 $p - Place of event (R) (Date/Time and Place of an Event) 034 $3 - Materials specified (NR) (Coded Cartographic Mathematical Data) 041 $j - Language code of subtitles or captions (Language code) 082 $m - Standard or Optional Designation (Dewey Decimal Classification Number) 082 $q - Assigning agency (Dewey Decimal Classification Number) 100 $0 - Authority record control number (Main entry -- Personal name) 110 $0 - Authority record control number (Main entry -- Corporate name) 111 $0 - Authority record control number (Main entry -- Meeting name) 130 $0 - Authority record control number (Main entry -- Uniform title) 240 $0 - Authority record control number (Uniform title) 257 $2 - Source (NR) (Country of Producing Entity) 440 $0 - Authority record control number (Series statement/Added entry -- Title) 440 $w - Bibliographic record control number (Series statement/Added entry -- Title) 490 $3 - Materials Specified (Series Statement) 502 $b - Degree Type (Dissertation Note) 502 $c - Name of Granting Institution (Dissertation Note) 502 $d - Year of Degree Granted (Dissertation Note) 502 $g - Miscellaneous Information (Dissertation Note) 502 $o - Dissertation Identifier (Dissertation Note) 510 $u - Uniform Resource Identifier (R) (Citation/References Note) 518 $0 - Record control number (R) (Date/Time and Place of an Event Note) 518 $2 - Source of term (R) (Date/Time and Place of an Event Note) 518 $d - Date of event (R) (Date/Time and Place of an Event Note) 518 $o - Other event information (R) (Date/Time and Place of an Event Note) 518 $p - Place of event (R) (Date/Time and Place of an Event Note) 520 $2 - Source (Summary, etc.) 520 $c - Assigning agency (Summary, etc.) 533 $5 - Institution to which field applies (Reproduction note) 534 $3 - Materials specified (NR) (Original Version Note) 534 $o - Other Resource Identifier (Original Version Note) 538 $5 - Institution to which field applies (System details note) 561 $u - Uniform Resource Identifier (R) (Ownership and Custodial History) 600 $0 - Authority record control number (Subject added entry -- Personal name) 610 $0 - Authority record control number (Subject added entry -- Corporate name) 611 $0 - Authority record control number (Subject added entry -- Meeting name) 630 $0 - Authority record control number (Subject added entry -- Uniform title) 648 $0 - Authority record control number (Subject added entry -- Chronological term) 650 $0 - Authority record control number (Subject added entry -- Topical term) 651 $0 - Authority record control number (Subject added entry -- Geographic name) 654 $0 - Authority record control number (Subject added entry -- Faceted topical terms) 655 $0 - Authority record control number (Index term -- Genre/form) 656 $0 - Authority record control number (Index term -- Occupation) 657 $0 - Authority record control number (Index term -- Function) 662 $0 - Authority record control number (Subject added entry -- Hierarchical place name) 700 $0 - Authority record control number (Added entry -- Personal name) 700 $i - Relationship information (R) (Added Entry-Personal Name) 710 $0 - Authority record control number (Added entry -- Corporate name) 710 $i - Relationship information (R) (Added Entry-Corporate Name) 711 $0 - Authority record control number (Added entry -- Meeting name) 711 $i - Relationship information (R) (Added Entry-Meeting Name) 730 $0 - Authority record control number (Added entry -- Uniform title) 730 $i - Relationship information (R) (Added Entry-Uniform Title) 752 $0 - Authority record control number (Added entry -- Hierarchical place name) 754 $0 - Authority record control number (Added entry -- Taxonomic identification) 760-787 $4 - Relationship code (R) (Linking Entry fields) 800 $0 - Authority record control number (Series added entry -- Personal name) 800 $3 - Materials Specified (Series Added Entry-Personal Name) 800 $5 - Institution to which field applies (R) (Series Added Entry-Personal Name) 800 $x - International Standard Serial Number (Series Added Entry-Personal Name) 810 $0 - Authority record control number (Series added entry -- Corporate name) 810 $3 - Materials Specified (Series Added Entry-Corporate Name) 810 $5 - Institution to which field applies (R) (Series Added Entry-Corporate Name) 810 $x - International Standard Serial Number (Series Added Entry-Corporate Name) 811 $0 - Authority record control number (Series added entry -- Meeting name) 811 $3 - Materials Specified (Series Added Entry-Meeting Name) 811 $5 - Institution to which field applies (R) (Series Added Entry-Meeting Name) 811 $x - International Standard Serial Number (Series Added Entry-Meeting Name) 830 $0 - Authority record control number (Series added entry -- Uniform title) 830 $3 - Materials Specified (Series Added Entry-Uniform Title) 830 $5 - Institution to which field applies (R) (Series Added Entry-Uniform Title) 830 $x - International Standard Serial Number (Series Added Entry-Uniform Title) 852 $d - Former shelving location (Location) -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5858 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff CC| |chris@bigballofwax.co.nz -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5858 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |frederic@tamil.fr --- Comment #5 from Frédéric Demians <frederic@tamil.fr> --- What prevents this patch to be signed-off? It seems all good. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5858 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- It seems it's not only adding, but also deleting a lot of fields? I did only look at the patch, maybe I am missing something. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5858 --- Comment #9 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I am not sure deleting them is a good idea - I would have to test it, but is there a chance we loose data if someone imports data that uses fields that are not defined in the default framework? I think I would prefer to see them hidden and marked [OBSOLETE] to be sure no data can be lost. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5858 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |In Discussion CC| |kyle@bywatersolutions.com -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5858 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bgkriegel@gmail.com --- Comment #12 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- (In reply to comment #9)

I am not sure deleting them is a good idea - I would have to test it, but is there a chance we loose data if someone imports data that uses fields that are not defined in the default framework? I think I would prefer to see them hidden and marked [OBSOLETE] to be sure no data can be lost.

I did some tests. Data is not lost when you import, in case some field is not present in frameworks. But if you edit and save the record, then it's lost. So, to prevent data loss, it would be convenient to hide the fields. I volunteer to write a followup to do that. Is that enough to proceed? The missing fields are real. Regards -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5858 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #10393|0 |1 is obsolete| | --- Comment #14 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Created attachment 15272 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15272&action=edit [SIGNED-OFF] Bug 5858 - Updating the marc21_framework_DEFAULT.sql to MARC21 version 14 Based on work in the Koha Kobli fork Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Comment: deleted fields added in a followup. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5858 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5858 --- Comment #17 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- I will check and resubmit. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5858 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #15272|0 |1 is obsolete| | -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5858 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #16445|0 |1 is obsolete| | --- Comment #19 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Created attachment 17352 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17352&action=edit Bug 5858 - Default frameworks missing many MARC21 tags This patch replaces previous ones. Only adds missing tags/subtags or update descriptions. Only to new installs. To test: 1) Delete MARC21 default framework 2) Apply patch 3) Test that new default framework loads without problem Rebased to master. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5858 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5858 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5858 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj@kohaaloha.com Summary|Default frameworks missing |Update default MARC21 |many MARC21 tags |framework to Update No. 16 | |(April 2013) -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5858 --- Comment #23 from Mason James <mtj@kohaaloha.com> --- (In reply to comment #20)

Created attachment 18584 [details] [review] Bug 5858 - Default frameworks missing many MARC21 tags

Signed-off-by: Mason James <mtj@kohaaloha.com>

i've taken a look a Bernardo's patch, and tested it it looks good -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5858 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl --- Comment #25 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- Looking at this now.. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5858 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|koha-bugs@lists.koha-commun |m.de.rooy@rijksmuseum.nl |ity.org | -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5858 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5858 --- Comment #29 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- (In reply to M. de Rooy from comment #28)

fatal: sha1 information is lacking or useless (installer/data/mysql/en/marcflavour/marc21/mandatory/ marc21_framework_DEFAULT.sql). Repository lacks necessary blobs to fall back on 3-way merge. Cannot fall back to three-way merge. Patch failed at 0001 Bug 5858 - Update default MARC21 framework to Update No. 16 (April 2013)

Strange ~/kohaclone$ git pull Already up-to-date. ~/kohaclone$ git checkout bug_5858-B Switched to branch 'bug_5858-B' Your branch is behind 'origin/master' by 11 commits, and can be fast-forwarded. ~/kohaclone$ git rebase master First, rewinding head to replay your work on top of it... Fast-forwarded bug_5858-B to master. ~/kohaclone$ git bz apply 5858 Bug 5858 - Update default MARC21 framework to Update No. 16 (April 2013) Bug 5858 - Default frameworks missing many MARC21 tags Apply? [yn] y Applying: Bug 5858 - Default frameworks missing many MARC21 tags [FOLLOWUP] Bug 5858 - Default frameworks missing many MARC21 tags Apply? [yn] y Applying: Bug 5858 - Default frameworks missing many MARC21 tags [FOLLOWUP 2] Bug 5858 - Update default MARC21 framework Apply? [yn] y Applying: Bug 5858 - Update default MARC21 framework to Update No. 16 (April 2013) ~/kohaclone$ For me it's applying without problem, should I switch to Needs Singoff? -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5858 --- Comment #31 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- Bernardo: I am getting further with Mason's patch when I use --ignore-whitespace on the patch file. Shall I continue? -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5858 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18584|0 |1 is obsolete| | --- Comment #33 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 19372 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19372&action=edit Bug 5858 - Default frameworks missing many MARC21 tags This patch is a *followup* to the previous patch Update MARC21 fields/subfields to version 16 http://www.loc.gov/marc/bibliographic/bdapndxg.html Only to new installs. To test: 1) Delete MARC21 default framework 2) Apply patch 3) Test that new default framework loads without problem Rebased to master. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5858 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff --- Comment #35 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- Sorry, couldn't wait. Yes, we are back in the air. Three patches applied. Will have a look again :) -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5858 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19330|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5858 --- Comment #36 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- I still need some time for these patches. Will hopefully finish this tomorrow. When squashing these patches, I again had the whitespace trouble. So we need some care with this set of patches. This is an impressive amount of work, Bernardo! -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5858 --- Comment #38 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- (In reply to M. de Rooy from comment #37)

Rest looks good to me. Please make final corrections for:

a) 046 $3 and 260 [You can probably amend Mason's patch, plz mention in commit] b) whitespace trouble

Changing status to reflect need for minor adjustments.

Thanks for testing!! I'll ammend and fix spaces and tags. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5858 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19371|0 |1 is obsolete| | Attachment #19372|0 |1 is obsolete| | Attachment #19373|0 |1 is obsolete| | --- Comment #40 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 19454 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19454&action=edit Bug 5858 - Default frameworks missing many MARC21 tags This patch combines original patch and two followups (with thanks to Mason). Patch has been recreated to recover from the whitespace errors coming back in the followups. The patch adds missing tags/subtags, or updates descriptions. Does only apply to new installs. We will still find a way to have current installs also/easier benefit from these changes too. To test: 1) Delete MARC21 default framework 2) Apply patch 3) Test that new default framework loads without problem Signed-off-by: Mason James <mtj@kohaaloha.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Run this file with and without this patch. This patch adds 24 tags (338 vs 314) and 323 subfields (3951 vs 3628). Verified that last QA comments were incorporated. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5858 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5858 --- Comment #42 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 19455 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19455&action=edit Bug 5858: Followup for INSERT IGNOREs in marc21_framework_DEFAULT.sql Changes 8 INSERTs into INSERT IGNOREs. This allows current installs to benefit easier from the new tags/subfields. Note that running with --force will not achieve the same! The multi-value inserts will still be aborted, though execution continues. Test plan: Run the file or do a new install. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Ran the file on a current install manually. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5858 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5858 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt@gmail.com --- Comment #45 from Galen Charlton <gmcharlt@gmail.com> --- Pushed to master. Thanks, Bernardo and Marcel! -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5858 --- Comment #47 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Pushed to 3.10.x, will be in 3.10.10 -- You are receiving this mail because: You are watching all bug changes.