[Bug 14046] New: CheckIfIssuedToPatron fails if biblionumber != biblioitemnumber
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14046 Bug ID: 14046 Summary: CheckIfIssuedToPatron fails if biblionumber != biblioitemnumber Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt@gmail.com Reporter: tomascohen@gmail.com QA Contact: testopia@bugs.koha-community.org If for some reason biblionumber!=biblioitemnumber (it happens with test DB's) CheckIfIssuedToPatron fails. It's logic should be rewritten. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14046 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14046 --- Comment #1 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 38341 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38341&action=edit Bug 14046: Make the CheckIfIssuedToPatron using the biblionumber C4::Circ::CheckIfIssuedToPatron called $items = GetItemsByBiblioitemnumber($biblionumber); But if biblionumber != biblioitemnumber, the items retrieved were not the good ones! Test plan: Make your Auto increment values for biblio and biblioitems differs Launch the tests: prove t/db_dependent/Circulation/CheckIfIssuedToPatron.t Before this patch, they did not pass. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14046 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38341|0 |1 is obsolete| | --- Comment #2 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 38342 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38342&action=edit [SIGNED OFF] Bug 14046: Make the CheckIfIssuedToPatron using the biblionumber C4::Circ::CheckIfIssuedToPatron called $items = GetItemsByBiblioitemnumber($biblionumber); But if biblionumber != biblioitemnumber, the items retrieved were not the good ones! Test plan: Make your Auto increment values for biblio and biblioitems differs Launch the tests: prove t/db_dependent/Circulation/CheckIfIssuedToPatron.t Before this patch, they did not pass. Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14046 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt@gmail.com |jonathan.druart@biblibre.co | |m Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14046 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14046 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38342|0 |1 is obsolete| | --- Comment #3 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 38348 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38348&action=edit [PASSED QA] Bug 14046: Make the CheckIfIssuedToPatron using the biblionumber C4::Circ::CheckIfIssuedToPatron called $items = GetItemsByBiblioitemnumber($biblionumber); But if biblionumber != biblioitemnumber, the items retrieved were not the good ones! Test plan: Make your Auto increment values for biblio and biblioitems differs Launch the tests: prove t/db_dependent/Circulation/CheckIfIssuedToPatron.t Before this patch, they did not pass. Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14046 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen@gmail.com --- Comment #4 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Patch pushed to master. Thanks Jonathan! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14046 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris@bigballofwax.co.nz Status|Pushed to Master |Pushed to Stable --- Comment #5 from Chris Cormack <chris@bigballofwax.co.nz> --- Pushed to 3.18.x will be in 3.18.7 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org