http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13817 --- Comment #1 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 36776 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36776&action=edit Bug 13817 - Edit links on course items may point to the wrong course! If items are assigned to multiple courses, the "edit" links for a course item may pass the wrong course id. This is really a cosmetic issue. It appears that in Template Toolkit, if you reuse an existing variable name in a foreach loop, it will not create a new temporary variable but will instead re-use the existing variable leaving assigned at the end to the last assignment, just as it would in Perl code. This is not a problem when all items are assigned to one and only one course, but can cause issues when we loop through the other courses an item may be on. This is solved easily by renaming the variable used in the foreach loop to another unused name. Test Plan: 1) Apply this patch 2) Try the edit and delete links for an item on reserve for a course 3) No changes in behavior should be noted -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13817 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |kyle@bywatersolutions.com |ity.org | CC| |nengard@gmail.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13817 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #36776|0 |1 is obsolete| | --- Comment #2 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 37383 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37383&action=edit Bug 13817 - Edit links on course items may point to the wrong course! If items are assigned to multiple courses, the "edit" links for a course item may pass the wrong course id. This is really a cosmetic issue. It appears that in Template Toolkit, if you reuse an existing variable name in a foreach loop, it will not create a new temporary variable but will instead re-use the existing variable leaving assigned at the end to the last assignment, just as it would in Perl code. This is not a problem when all items are assigned to one and only one course, but can cause issues when we loop through the other courses an item may be on. This is solved easily by renaming the variable used in the foreach loop to another unused name. Test Plan: 1) Apply this patch 2) Try the edit and delete links for an item on reserve for a course 3) No changes in behavior should be noted Signed-off-by: Tom Misilo <misilot@fit.edu> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13817 --- Comment #3 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- QA: Picking a trivial one now; spent hours in Search.pm :) -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13817 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37383|0 |1 is obsolete| | --- Comment #4 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 38057 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38057&action=edit Bug 13817 - Edit links on course items may point to the wrong course! If items are assigned to multiple courses, the "edit" links for a course item may pass the wrong course id. This is really a cosmetic issue. It appears that in Template Toolkit, if you reuse an existing variable name in a foreach loop, it will not create a new temporary variable but will instead re-use the existing variable leaving assigned at the end to the last assignment, just as it would in Perl code. This is not a problem when all items are assigned to one and only one course, but can cause issues when we loop through the other courses an item may be on. This is solved easily by renaming the variable used in the foreach loop to another unused name. Test Plan: 1) Apply this patch 2) Try the edit and delete links for an item on reserve for a course 3) No changes in behavior should be noted Signed-off-by: Tom Misilo <misilot@fit.edu> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13817 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen@gmail.com --- Comment #6 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Patch pushed to master. Thanks Kyle! -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13817 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris@bigballofwax.co.nz Status|Pushed to Master |Pushed to Stable --- Comment #7 from Chris Cormack <chris@bigballofwax.co.nz> --- Pushed to 3.18.x will be in 3.18.7 -- You are receiving this mail because: You are watching all bug changes.