[Bug 18117] New: Convert browser alerts to modals
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18117 Bug ID: 18117 Summary: Convert browser alerts to modals Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt@gmail.com Reporter: cbrannon@cdalibrary.org QA Contact: testopia@bugs.koha-community.org With modals becoming more active in Koha, I think we need to move away from alert messages and stick with modals. Alert messages look different from browser to browser, and you have less/no control over the look and feel of the alert. Modals would allow for more enhancement, such as color and sound, if someone chose that. The big concern is consistency. We lack consistency between alerts and modals, and with alerts between browsers. I would proposed a stop on use of alert messages, and convert existing uses of alerts to modal. That's my opinion. Would like to hear others. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18117 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de, | |oleonard@myacpl.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18117 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- I think it's important to distinguish between a couple of different situations in which we ask the user for confirmation of an action: - "Simple" delete confirmations, where we ask "Are you sure? Yes/No" -- Usually a JS alert - Confirmation requests which display more information for the user to consider before they confirm. Commonly seen in Administration scripts. The latter of those two seem more suited to conversion to modals, although it would require API work to ensure that the additional information could be pulled via AJAX for display in the modal. For instance: "This library cannot be deleted. Patrons or items are still using it." Personally I think the ease and speed of a JavaScript alert makes it appropriate for simple delete confirmations. All modal operations come with the added overhead of more code and are slower to operate. I don't find the visual consistency between browsers to be an issue. I would think people know what their browser's alerts look like and are not concerned that they look different from another browser's alert. Going forward I think we should keep in mind that the conversion to modals isn't simple template work (for the AJAXy reason above) and without that problem prepared for we'll still be stuck with inconsistency for quite a while. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18117 Christopher Brannon <cbrannon@cdalibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |FIXED --- Comment #2 from Christopher Brannon <cbrannon@cdalibrary.org> --- We seem to be moving in this direction. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18117 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|FIXED |--- Status|RESOLVED |REOPENED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18117 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|REOPENED |NEW --- Comment #3 from Owen Leonard <oleonard@myacpl.org> --- I would like to keep this open because I have some patches in progress. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18117 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |21870 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21870 [Bug 21870] Convert browser alerts to modals: OPAC user summary -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18117 Christopher Brannon <cbrannon@cdalibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=21346 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18117 Bug 18117 depends on bug 21870, which changed state. Bug 21870 Summary: Convert browser alerts to modals: OPAC user summary https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21870 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18117 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |25280 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25280 [Bug 25280] Use modal confirmation when removing share from a list in the OPAC -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18117 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |25281 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25281 [Bug 25281] Use modal confirmation when deleting a list in the OPAC -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18117 --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Owen Leonard from comment #3)
I would like to keep this open because I have some patches in progress.
Owen, should this still remain open? Linked bugs have been all resolved. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18117 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|NEW |RESOLVED --- Comment #5 from Owen Leonard <oleonard@myacpl.org> --- (In reply to Katrin Fischer from comment #4)
Owen, should this still remain open? Linked bugs have been all resolved.
I'm not actively working on any more instances of this issue so I think it can be closed. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org