[Bug 32515] New: SIP2 no block flag on checkin calls routine that does not exist
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32515 Bug ID: 32515 Summary: SIP2 no block flag on checkin calls routine that does not exist Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: SIP2 Assignee: koha-bugs@lists.koha-community.org Reporter: nick@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org git grep "checkin_no_block" C4/SIP/Sip/MsgType.pm: $status = $ils->checkin_no_block( $item_id, $trans_date, $return_date, $item_props, $cancel ); -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32515 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |12225 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12225 [Bug 12225] SIP does not respect the "no block" flag -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32515 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32515 --- Comment #1 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 144856 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144856&action=edit Bug 32515: Ignore no-block flag in check-in message Bug 12225 changed the templates to correctly pass through the no-block flag, however, we don't have a no-block routine for checkins This patch restore previous behaviour of performing a normal checkin when no block was requested - it adds a new FIXME To test: 1 - See bug 32537 https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32537 2 - Repeat test plan on that bug, noting that there is no response when no-block = Y 3 - Apply this patch 4 - Repeat the tests and confirm no-block = Y has a standard checkin response -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32515 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |nick@bywatersolutions.com |ity.org | Severity|normal |major -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32515 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com --- Comment #2 from David Nind <david@davidnind.com> --- To test, I: 1. Repeated the steps in bug 32537 (including applying that patch). 2. Applied this patch and restarted SIP (koha-sip --restart kohadev). 3. The response I got for step 4 was: root@kohadevbox:koha(bz32515)$ perl misc/sip_cli_emulator.pl -a localhost -p 6001 -l CPL -su term1 -sp term1 -m checkin --item 39999000011418 -n Y Attempting socket connection to localhost:6001...connected! Use of uninitialized value $hold_mode in string eq at misc/sip_cli_emulator.pl line 124. SEND: 9300CNterm1|COterm1|CPCPL| READ: 941 Trying 'checkin' SEND: 09Y20230101 21213820230101 212138APCPL|AOCPL|AB39999000011418|ACterm1|BIN| Use of uninitialized value $data in concatenation (.) or string at misc/sip_cli_emulator.pl line 356, <GEN0> chunk 1. READ: I'm not sure if this is what is expected (as it is pretty similar to what I got for bug 32537, except the second and third series of numbers in the SEND are different), but happy to sign off if it is. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32515 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=32537 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32515 --- Comment #3 from Nick Clemens <nick@bywatersolutions.com> --- (In reply to David Nind from comment #2)
I'm not sure if this is what is expected (as it is pretty similar to what I got for bug 32537, except the second and third series of numbers in the SEND are different), but happy to sign off if it is.
Hi David, It looks like the SIP response is still failing on no-block, but I don't recreate Could you retest with 'restart_all' rather than just SIP to see if that works? Or try koha-sip --stop, confirm stopped, then koha-sip --start? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32515 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |32557 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32557 [Bug 32557] Implement SIP2 no block flag for checkin messages -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32515 --- Comment #4 from David Nind <david@davidnind.com> --- (In reply to Nick Clemens from comment #3)
(In reply to David Nind from comment #2)
I'm not sure if this is what is expected (as it is pretty similar to what I got for bug 32537, except the second and third series of numbers in the SEND are different), but happy to sign off if it is.
Hi David,
It looks like the SIP response is still failing on no-block, but I don't recreate
Could you retest with 'restart_all' rather than just SIP to see if that works? Or try koha-sip --stop, confirm stopped, then koha-sip --start?
I'm getting a response now, so will sign off! The response is now: root@kohadevbox:koha(bz32515)$ perl misc/sip_cli_emulator.pl -a localhost -p 6001 -l CPL -su term1 -sp term1 -m checkin --item 39999000011418 -n Y Attempting socket connection to localhost:6001...connected! Use of uninitialized value $hold_mode in string eq at misc/sip_cli_emulator.pl line 123. SEND: 9300CNterm1|COterm1|CPCPL| READ: 941 Trying 'checkin' SEND: 09Y20230103 23115420230103 231154APCPL|AOCPL|AB39999000011418|ACterm1|BIN| READ: 101YNN20230103 231155AOCPL|AB39999000011418|AQCPL|AJProgramming Perl /|CRREF| Maybe I forgot to flush_memcached and restart_all after stopping and starting SIP 8-; -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32515 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32515 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #144856|0 |1 is obsolete| | --- Comment #5 from David Nind <david@davidnind.com> --- Created attachment 144963 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144963&action=edit Bug 32515: Ignore no-block flag in check-in message Bug 12225 changed the templates to correctly pass through the no-block flag, however, we don't have a no-block routine for checkins This patch restore previous behaviour of performing a normal checkin when no block was requested - it adds a new FIXME To test: 1 - See bug 32537 https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32537 2 - Repeat test plan on that bug, noting that there is no response when no-block = Y 3 - Apply this patch 4 - Repeat the tests and confirm no-block = Y has a standard checkin response Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32515 Blou <philippe.blouin@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #144963|0 |1 is obsolete| | --- Comment #6 from Blou <philippe.blouin@inlibro.com> --- Created attachment 145370 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145370&action=edit Bug 32515: Ignore no-block flag in check-in message Bug 12225 changed the templates to correctly pass through the no-block flag, however, we don't have a no-block routine for checkins This patch restore previous behaviour of performing a normal checkin when no block was requested - it adds a new FIXME To test: 1 - See bug 32537 https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32537 2 - Repeat test plan on that bug, noting that there is no response when no-block = Y 3 - Apply this patch 4 - Repeat the tests and confirm no-block = Y has a standard checkin response Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Blou <philippe.blouin@inlibro.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32515 Blou <philippe.blouin@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |philippe.blouin@inlibro.com --- Comment #7 from Blou <philippe.blouin@inlibro.com> --- Tested in production with my customers, does fix the important issue in 22.05.06 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32515 David Kuhn <techservspec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |techservspec@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32515 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #145370|0 |1 is obsolete| | --- Comment #8 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 145943 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145943&action=edit Bug 32515: Ignore no-block flag in check-in message Bug 12225 changed the templates to correctly pass through the no-block flag, however, we don't have a no-block routine for checkins This patch restore previous behaviour of performing a normal checkin when no block was requested - it adds a new FIXME To test: 1 - See bug 32537 https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32537 2 - Repeat test plan on that bug, noting that there is no response when no-block = Y 3 - Apply this patch 4 - Repeat the tests and confirm no-block = Y has a standard checkin response Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Blou <philippe.blouin@inlibro.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32515 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com Status|Signed Off |Passed QA --- Comment #9 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Damn, annoying that we missed this in the prior bug. Still, the quick fix here works around it.. we should certainly look into implementing bug 32557 though. Passing QA as this gets us out of a hole and all works. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32515 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |martin.renvoize@ptfs-europe |y.org |.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32515 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen@gmail.com --- Comment #10 from Tomás Cohen Arazi <tomascohen@gmail.com> --- (In reply to Martin Renvoize from comment #8)
Bug 12225 changed the templates to correctly pass through the no-block flag, however, we don't have a no-block routine for checkins
^^ any chance we can have a regression test? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32515 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |23.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32515 --- Comment #11 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32515 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.05.00 |23.05.00,22.11.03 released in| | Status|Pushed to master |Pushed to stable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32515 --- Comment #12 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Nice work everyone! Pushed to stable for 22.11.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32515 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com Version(s)|23.05.00,22.11.03 |23.05.00,22.11.03,22.05.10 released in| | Status|Pushed to stable |Pushed to oldstable --- Comment #13 from Lucas Gass <lucas@bywatersolutions.com> --- Backported to 22.05.x for 22.05.10 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32515 Bug 32515 depends on bug 12225, which changed state. Bug 12225 Summary: SIP does not respect the "no block" flag https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12225 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32515 Arthur Suzuki <arthur.suzuki@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED CC| |arthur.suzuki@biblibre.com Status|Pushed to oldstable |RESOLVED --- Comment #14 from Arthur Suzuki <arthur.suzuki@biblibre.com> --- depends on 12225 which I failed to backport to 21.11.x. Can't backport this one either then. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32515 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=32516 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org