[Bug 22874] New: Limit to available items doesn't work with elasticsearch 6.x
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22874 Bug ID: 22874 Summary: Limit to available items doesn't work with elasticsearch 6.x Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Searching - Elasticsearch Assignee: koha-bugs@lists.koha-community.org Reporter: alex.arnaud@biblibre.com Target Milestone: --- Currently we send "onloan:0" to ES to get records with available items. But ES 6 does not considers 0 as a valid boolean. On ES 6.x: onloan:0 => doesn't work onloan:false => works On ES 5.x: onloan:0 => works onloan:false => works So it seems we can have compatibility for both ES 5 and ES 6 by using false instead of 0. Patch is coming. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22874 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |alex.arnaud@biblibre.com |ity.org | Blocks| |20196 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20196 [Bug 20196] [Omnibus] Prepare Koha to ElasticSearch6 - ES6 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22874 --- Comment #1 from Alex Arnaud <alex.arnaud@biblibre.com> --- Created attachment 89506 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89506&action=edit Bug 22874 - use false instaed of 0 value for limiting on availability Test plan - Set up a elasticsearch 6 instance to work with Koha, - you may need to make koha works with ES 6 (see bug 20589), - make a search and limit it to available items only, => no result - Apply this patch, - make a search and limit it to available items only, - you should get some results - Do the same with ES 5.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22874 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22874 e.betemps <e.betemps@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |e.betemps@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22874 Michal Denar <black23@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |black23@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22874 Séverine Queune <severine.queune@bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |severine.queune@bulac.fr --- Comment #2 from Séverine Queune <severine.queune@bulac.fr> --- Here are the 2 sandboxes I used with : - ES5 : http://pro.es5-koha.sandbox.biblibre.eu - ES6 : http://pro.es6-koha.sandbox.biblibre.eu Sorry Alex, they both failed... -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22874 sandboxes@biblibre.com <sandboxes@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off CC| |sandboxes@biblibre.com --- Comment #3 from sandboxes@biblibre.com <sandboxes@biblibre.com> --- Patch tested with a sandbox, by Séverine QUEUNE <severine.queune@bulac.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22874 sandboxes@biblibre.com <sandboxes@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #89506|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22874 --- Comment #4 from sandboxes@biblibre.com <sandboxes@biblibre.com> --- Created attachment 93359 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93359&action=edit Bug 22874 - use false instaed of 0 value for limiting on availability Test plan - Set up a elasticsearch 6 instance to work with Koha, - you may need to make koha works with ES 6 (see bug 20589), - make a search and limit it to available items only, => no result - Apply this patch, - make a search and limit it to available items only, - you should get some results - Do the same with ES 5.x Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22874 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22874 --- Comment #5 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 94792 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94792&action=edit Bug 22874: Use false instaed of 0 value for limiting on availability Test plan - Set up a elasticsearch 6 instance to work with Koha, - you may need to make koha works with ES 6 (see bug 20589), - make a search and limit it to available items only, => no result - Apply this patch, - make a search and limit it to available items only, - you should get some results - Do the same with ES 5.x Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22874 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com Attachment #93359|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22874 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |19.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22874 --- Comment #6 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Nice work! Pushed to master for 19.11.00 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org