https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22114 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec@gmail.com Blocks| |22490 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22490 [Bug 22490] Some strings in javascript files are untranslatable -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22114 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 93749 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93749&action=edit Bug 22114: Untranslatable "Patron note:" in checkout.js This patch modifies JavaScript used in circulation, replacing an untranslatable English string in the script with a variable defined in strings.inc which can be translated. To test you should have the AllowCheckoutNotes system preference enabled. - Apply the patch and log in to the OPAC as a user who has two or more items checked out. - From the list of checkouts on the "Your summary" page, add a note to two or more checked-out items. - Log in to the staff client and open the checkout page for that user. - In the table of checkouts, check the "Check in" checkbox next to one of the titles you added a note to. - Click "Renew or check in selected items." - A message should appear in that table row showing your note, prefixed with the text "Patron note:" To test translation, update and install the de-DE template:

cd misc/translator perl translate update de-DE perl translate install de-DE

- Go to Administration -> System preferences and enable the "Deutsch (de-DE)" language under I18N/L10N preferences -> language. - Switch to the "Deutsch" translation. - Go to Ausleihe (Circulation) and check out to the same patron. - In the table of checkouts, check the checkbox in the "Rückgabe" column next to another title you added a note to. - Click the "Markierte Exemplare zurückgeben oder verlängern" button. - A message should appear in that table row showing your note prefixed with the text "Benutzernotizen:" -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22114 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22114 --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Very impressed with the German in the commit message! -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22114 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #94108|0 |1 is obsolete| | --- Comment #4 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 94795 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94795&action=edit Bug 22114: Untranslatable "Patron note:" in checkout.js This patch modifies JavaScript used in circulation, replacing an untranslatable English string in the script with a variable defined in strings.inc which can be translated. To test you should have the AllowCheckoutNotes system preference enabled. - Apply the patch and log in to the OPAC as a user who has two or more items checked out. - From the list of checkouts on the "Your summary" page, add a note to two or more checked-out items. - Log in to the staff client and open the checkout page for that user. - In the table of checkouts, check the "Check in" checkbox next to one of the titles you added a note to. - Click "Renew or check in selected items." - A message should appear in that table row showing your note, prefixed with the text "Patron note:" To test translation, update and install the de-DE template:

cd misc/translator perl translate update de-DE perl translate install de-DE

- Go to Administration -> System preferences and enable the "Deutsch (de-DE)" language under I18N/L10N preferences -> language. - Switch to the "Deutsch" translation. - Go to Ausleihe (Circulation) and check out to the same patron. - In the table of checkouts, check the checkbox in the "Rückgabe" column next to another title you added a note to. - Click the "Markierte Exemplare zurückgeben oder verlängern" button. - A message should appear in that table row showing your note prefixed with the text "Benutzernotizen:" Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22114 --- Comment #5 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Nice work! Pushed to master for 19.11.00 -- You are receiving this mail because: You are watching all bug changes.