[Bug 26456] New: Reindent MARC subfield structure template
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26456 Bug ID: 26456 Summary: Reindent MARC subfield structure template Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org CC: testopia@bugs.koha-community.org I propose to reformat the MARC subfield structure template (marc_subfields_structure.tt) so that it has consistent spacing and indentation. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26456 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26456 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 110065 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110065&action=edit Bug 26456: Reindent MARC subfield structure template This patch reindents the MARC subfield structure template. The only non-whitespace changes where lines were combined or split. The diff using the '-w' flag to ignore whitespace should highlight only moved lines. Test that functionality is unaffected: Administration -> MARC bibliographic framework -> MARC structure -> Edit subfields.. Test adding, editing, and deleting subfields. Confirm that changes are saved correctly. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26456 --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 110066 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110066&action=edit Bug 26456: (follow-up) Add markup comments This patch adds comments to the template to highlight the markup structure. Also changed: Some form hints have been wrapped in <div class="hint"> to make it consistent with other pages. This patch should have no effect on functionality. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26456 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |david@davidnind.com --- Comment #3 from David Nind <david@davidnind.com> --- Patch no longer applies 8-( -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26456 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26456 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #110065|0 |1 is obsolete| | Attachment #110066|0 |1 is obsolete| | --- Comment #4 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 111306 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111306&action=edit Bug 26456: Reindent MARC subfield structure template This patch reindents the MARC subfield structure template. The only non-whitespace changes where lines were combined or split. The diff using the '-w' flag to ignore whitespace should highlight only moved lines. Test that functionality is unaffected: Administration -> MARC bibliographic framework -> MARC structure -> Edit subfields.. Test adding, editing, and deleting subfields. Confirm that changes are saved correctly. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26456 --- Comment #5 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 111307 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111307&action=edit Bug 26456: (follow-up) Add markup comments This patch adds comments to the template to highlight the markup structure. Also changed: Some form hints have been wrapped in <div class="hint"> to make it consistent with other pages. This patch should have no effect on functionality. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26456 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26456 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #111306|0 |1 is obsolete| | --- Comment #6 from David Nind <david@davidnind.com> --- Created attachment 111363 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111363&action=edit Bug 26456: Reindent MARC subfield structure template This patch reindents the MARC subfield structure template. The only non-whitespace changes where lines were combined or split. The diff using the '-w' flag to ignore whitespace should highlight only moved lines. Test that functionality is unaffected: Administration -> MARC bibliographic framework -> MARC structure -> Edit subfields.. Test adding, editing, and deleting subfields. Confirm that changes are saved correctly. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26456 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #111307|0 |1 is obsolete| | --- Comment #7 from David Nind <david@davidnind.com> --- Created attachment 111364 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111364&action=edit Bug 26456: (follow-up) Add markup comments This patch adds comments to the template to highlight the markup structure. Also changed: Some form hints have been wrapped in <div class="hint"> to make it consistent with other pages. This patch should have no effect on functionality. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26456 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26456 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #111363|0 |1 is obsolete| | --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 111560 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111560&action=edit Bug 26456: Reindent MARC subfield structure template This patch reindents the MARC subfield structure template. The only non-whitespace changes where lines were combined or split. The diff using the '-w' flag to ignore whitespace should highlight only moved lines. Test that functionality is unaffected: Administration -> MARC bibliographic framework -> MARC structure -> Edit subfields.. Test adding, editing, and deleting subfields. Confirm that changes are saved correctly. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26456 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #111364|0 |1 is obsolete| | --- Comment #9 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 111561 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111561&action=edit Bug 26456: (follow-up) Add markup comments This patch adds comments to the template to highlight the markup structure. Also changed: Some form hints have been wrapped in <div class="hint"> to make it consistent with other pages. This patch should have no effect on functionality. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26456 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |20.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26456 --- Comment #10 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 20.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26456 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com --- Comment #11 from Lucas Gass <lucas@bywatersolutions.com> --- enhancement will not be backported to 20.05.x -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org